From patchwork Mon Jun 26 13:40:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Disseldorp X-Patchwork-Id: 9809729 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5339D60329 for ; Mon, 26 Jun 2017 13:42:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58A77285A6 for ; Mon, 26 Jun 2017 13:42:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D5E4285C1; Mon, 26 Jun 2017 13:42:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E173F285A6 for ; Mon, 26 Jun 2017 13:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751308AbdFZNmO (ORCPT ); Mon, 26 Jun 2017 09:42:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:41882 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751466AbdFZNkw (ORCPT ); Mon, 26 Jun 2017 09:40:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7ADB7AB5D for ; Mon, 26 Jun 2017 13:40:46 +0000 (UTC) From: David Disseldorp To: fstests@vger.kernel.org Cc: David Disseldorp Subject: [PATCH 2/2] common: remove tmp.mkfs[err/std] files by name Date: Mon, 26 Jun 2017 15:40:17 +0200 Message-Id: <20170626134017.2741-2-ddiss@suse.de> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170626134017.2741-1-ddiss@suse.de> References: <20170626134017.2741-1-ddiss@suse.de> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without any $tmp suffix, users silly enough to run xfstests without mktemp present will unintentionally "rm -f *". Signed-off-by: David Disseldorp --- common/rc | 2 +- common/xfs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/rc b/common/rc index ff1b75c9..a38f4e03 100644 --- a/common/rc +++ b/common/rc @@ -595,7 +595,7 @@ _scratch_do_mkfs() cat $tmp.mkfsstd eval "cat $tmp.mkfserr | $mkfs_filter" >&2 - rm -f $tmp* + rm -f $tmp.mkfsstd $tmp.mkfserr return $mkfs_status } diff --git a/common/xfs b/common/xfs index 0f0825bc..59776a6f 100644 --- a/common/xfs +++ b/common/xfs @@ -104,7 +104,7 @@ _scratch_mkfs_xfs() # output mkfs stdout and stderr cat $tmp.mkfsstd cat $tmp.mkfserr >&2 - rm -f $tmp* + rm -f $tmp.mkfsstd $tmp.mkfserr return $mkfs_status }