new file mode 100755
@@ -0,0 +1,98 @@
+#! /bin/bash
+# FS QA Test 449
+#
+# Fill the device and set as many extended attributes to a file as
+# possible. Then call setfacl on it and, if this fails for lack of
+# space, test that the permissions remain the same.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2017 Ernesto A. Fernandez. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/attr
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+_require_test
+_require_acls
+_require_attrs
+
+_scratch_mkfs_sized $((50 * 1024 * 1024)) >> $seqres.full 2>&1
+_scratch_mount || _fail "mount failed"
+
+TFILE=$SCRATCH_MNT/testfile.$seq
+
+# Create the test file and choose its permissions
+touch $TFILE
+chmod u+rwx $TFILE
+chmod go-rwx $TFILE
+
+# Try to run out of space so setfacl will fail
+$XFS_IO_PROG -c "pwrite 0 50m" $TFILE >>$seqres.full 2>&1
+i=1
+j=1
+ret=0
+while [ $ret -eq 0 ]; do
+ ret=1
+ while [ $j -le 1000 ]; do
+ # On btrfs, setfattr will sometimes fail when free space is
+ # low, long before it's actually exhausted. Insist until it
+ # fails consistently.
+ setfattr -n user.$i"x"$j $TFILE &>/dev/null
+ ret=$(( $ret && $? ))
+ ((++j))
+ done
+ j=1
+ ((++i))
+done
+
+if setfacl -m m:r $TFILE &>/dev/null; then
+ # setfacl succeeded, so the test was meaningless
+ # The filesystem might still have an issue
+ _notrun "$FSTYP succeeds in setting acls despite running out of space for user attrs"
+fi
+
+# Since setfacl failed, the permissions should not have changed
+stat -c %A $TFILE
+
+status=0
+exit
new file mode 100644
@@ -0,0 +1,2 @@
+QA output created by 449
+-rwx------
@@ -451,3 +451,4 @@
446 auto quick rw dangerous
447 auto quick clone
448 auto quick rw
+449 auto quick acl
Check that the group permission bits of a file are not altered when setfacl fails. At the time of this patch the test fails for at least ext2, ext4, jfs and btrfs. The failure in setfacl is induced by filling the device and setting as many user attributes to the file as possible. For xfs this is not enough, and the test will not run. Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> --- Changes in v4: - Continue to set attributes even when the filesystem claims to be out of space. With this change the test will now fail for btrfs. - Call _notrun when setfacl succeeds, since no check can be done. As suggested by Eryu Guan. Changes in v3: - Several fixes requested by Eryu Guan (thank you for your review), most importantly: - Place the jfs support in a separate patch, already sent. - Make the test fail when the scratch device does not mount, so rootfs won't be filled. - Add the test to auto and quick groups. Changes in v2: - Use the scratch dev instead of the test dev so we can make a small fs and fill it faster. As suggested by Christoph Hellwig. - Make jfs work with _scratch_mkfs_sized, needed for the above. - Remove the mention to an issue with reiserfs, since I now believe the problem is on their side. tests/generic/449 | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/449.out | 2 ++ tests/generic/group | 1 + 3 files changed, 101 insertions(+) create mode 100755 tests/generic/449 create mode 100644 tests/generic/449.out