Message ID | 20171122123215.32292-1-rgoldwyn@suse.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Nov 22, 2017 at 06:32:14AM -0600, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues <rgoldwyn@suse.com> > > Tests the RWF_NOWAIT flag so the I/O returns immediately with -EAGAIN > on a new file since it requires block allocation. > > It creates a file, syncs it, and overwrites the file with RWF_NOWAIT. > This should succeed. > > Finally, read the contents to make sure the overwrite is successful. > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> > --- > tests/generic/470 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/470.out | 9 +++++++ > tests/generic/group | 1 + > 3 files changed, 83 insertions(+) > create mode 100644 tests/generic/470 > create mode 100644 tests/generic/470.out > > diff --git a/tests/generic/470 b/tests/generic/470 > new file mode 100644 > index 00000000..8a742258 > --- /dev/null > +++ b/tests/generic/470 > @@ -0,0 +1,73 @@ > +#! /bin/bash > +# FS QA Test No. 470 > +# > +# write() to a file opened with O_DIRECT with count > remaining > +# bytes. Result should be remaining bytes (to aligned bytes) instead > +# of ENOSPC error > +# > +#----------------------------------------------------------------------- > +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved. > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#----------------------------------------------------------------------- > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -rf $tmp.* $testdir1 $testdir, not $testdir1? > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/populate > +. ./common/filter > +. ./common/attr > + > +# real QA test starts here > +_supported_os Linux > +_require_odirect > +_require_scratch > + > +_scratch_mkfs > /dev/null 2>&1 > +_scratch_mount > /dev/null 2>&1 > +testdir=$SCRATCH_MNT/test-$seq > +mkdir $testdir > + > +# Create a file with pwrite nowait (will fail with EAGAIN) > +xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1 $XFS_IO_PROG, not xfs_io Also does this test need _require_xfs_io_command pwrite -N ? > + > +# Write the file without nowait > +xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io > + > +time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'` > +if (( $(echo "$time_taken < 0.05" | bc -l) )); then We're assuming that the hardware is capable of handling a direct write 64M in under 51ms, correct? I'm not sure my disks can do that. --D > + echo "RWF_NOWAIT time is within limits." > +else > + echo "RWF_NOWAIT took $time_taken seconds" > +fi > + > +xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique > + > +# success, all done > +status=0 > +exit > diff --git a/tests/generic/470.out b/tests/generic/470.out > new file mode 100644 > index 00000000..73a210b4 > --- /dev/null > +++ b/tests/generic/470.out > @@ -0,0 +1,9 @@ > +QA output created by 470 > +pwrite: Resource temporarily unavailable > +wrote 134217728/134217728 bytes at offset 0 > +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > +RWF_NOWAIT time is within limits. > +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................ > +* > +read 2097152/2097152 bytes at offset 0 > +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > diff --git a/tests/generic/group b/tests/generic/group > index 6c3bb03a..11ccfb01 100644 > --- a/tests/generic/group > +++ b/tests/generic/group > @@ -472,3 +472,4 @@ > 467 auto quick exportfs > 468 shutdown auto quick metadata > 469 auto quick > +470 auto quick > -- > 2.14.2 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/22/2017 11:42 AM, Darrick J. Wong wrote: > On Wed, Nov 22, 2017 at 06:32:14AM -0600, Goldwyn Rodrigues wrote: >> From: Goldwyn Rodrigues <rgoldwyn@suse.com> >> >> Tests the RWF_NOWAIT flag so the I/O returns immediately with -EAGAIN >> on a new file since it requires block allocation. >> >> It creates a file, syncs it, and overwrites the file with RWF_NOWAIT. >> This should succeed. >> >> Finally, read the contents to make sure the overwrite is successful. >> >> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> >> --- >> tests/generic/470 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> tests/generic/470.out | 9 +++++++ >> tests/generic/group | 1 + >> 3 files changed, 83 insertions(+) >> create mode 100644 tests/generic/470 >> create mode 100644 tests/generic/470.out >> >> diff --git a/tests/generic/470 b/tests/generic/470 >> new file mode 100644 >> index 00000000..8a742258 >> --- /dev/null >> +++ b/tests/generic/470 >> @@ -0,0 +1,73 @@ >> +#! /bin/bash >> +# FS QA Test No. 470 >> +# >> +# write() to a file opened with O_DIRECT with count > remaining >> +# bytes. Result should be remaining bytes (to aligned bytes) instead >> +# of ENOSPC error >> +# >> +#----------------------------------------------------------------------- >> +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved. >> +# >> +# This program is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU General Public License as >> +# published by the Free Software Foundation. >> +# >> +# This program is distributed in the hope that it would be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write the Free Software Foundation, >> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> +#----------------------------------------------------------------------- >> + >> +seq=`basename $0` >> +seqres=$RESULT_DIR/$seq >> +echo "QA output created by $seq" >> + >> +here=`pwd` >> +tmp=/tmp/$$ >> +status=1 # failure is the default! >> +trap "_cleanup; exit \$status" 0 1 2 3 15 >> + >> +_cleanup() >> +{ >> + cd / >> + rm -rf $tmp.* $testdir1 > > $testdir, not $testdir1? > >> +} >> + >> +# get standard environment, filters and checks >> +. ./common/rc >> +. ./common/populate >> +. ./common/filter >> +. ./common/attr >> + >> +# real QA test starts here >> +_supported_os Linux >> +_require_odirect >> +_require_scratch >> + >> +_scratch_mkfs > /dev/null 2>&1 >> +_scratch_mount > /dev/null 2>&1 >> +testdir=$SCRATCH_MNT/test-$seq >> +mkdir $testdir >> + >> +# Create a file with pwrite nowait (will fail with EAGAIN) >> +xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1 > > $XFS_IO_PROG, not xfs_io > > Also does this test need _require_xfs_io_command pwrite -N ? Yes, I was looking for something with version compatibility. Thanks. > >> + >> +# Write the file without nowait >> +xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io >> + >> +time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'` >> +if (( $(echo "$time_taken < 0.05" | bc -l) )); then > > We're assuming that the hardware is capable of handling a direct write > 64M in under 51ms, correct? I'm not sure my disks can do that. Yes, though a little different. The blocks are already allocated so it should be fast. I will add a comment. > > --D > >> + echo "RWF_NOWAIT time is within limits." >> +else >> + echo "RWF_NOWAIT took $time_taken seconds" >> +fi >> + >> +xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique >> + >> +# success, all done >> +status=0 >> +exit >> diff --git a/tests/generic/470.out b/tests/generic/470.out >> new file mode 100644 >> index 00000000..73a210b4 >> --- /dev/null >> +++ b/tests/generic/470.out >> @@ -0,0 +1,9 @@ >> +QA output created by 470 >> +pwrite: Resource temporarily unavailable >> +wrote 134217728/134217728 bytes at offset 0 >> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> +RWF_NOWAIT time is within limits. >> +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................ >> +* >> +read 2097152/2097152 bytes at offset 0 >> +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> diff --git a/tests/generic/group b/tests/generic/group >> index 6c3bb03a..11ccfb01 100644 >> --- a/tests/generic/group >> +++ b/tests/generic/group >> @@ -472,3 +472,4 @@ >> 467 auto quick exportfs >> 468 shutdown auto quick metadata >> 469 auto quick >> +470 auto quick >> -- >> 2.14.2 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe fstests" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/generic/470 b/tests/generic/470 new file mode 100644 index 00000000..8a742258 --- /dev/null +++ b/tests/generic/470 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test No. 470 +# +# write() to a file opened with O_DIRECT with count > remaining +# bytes. Result should be remaining bytes (to aligned bytes) instead +# of ENOSPC error +# +#----------------------------------------------------------------------- +# Copyright (c) 2017, SUSE Linux Products. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -rf $tmp.* $testdir1 +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/populate +. ./common/filter +. ./common/attr + +# real QA test starts here +_supported_os Linux +_require_odirect +_require_scratch + +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount > /dev/null 2>&1 +testdir=$SCRATCH_MNT/test-$seq +mkdir $testdir + +# Create a file with pwrite nowait (will fail with EAGAIN) +xfs_io -f -d -c "pwrite -N -V 1 -b 128M 0 128M" $testdir/f1 + +# Write the file without nowait +xfs_io -f -d -c "pwrite -S 0xaa -W -w -V 1 -b 128M 0 128M" $testdir/f1 | _filter_xfs_io + +time_taken=`xfs_io -d -c "pwrite -N -V 1 -b 64M 0 64M" $testdir/f1 | awk '/^64/ {print $5}'` +if (( $(echo "$time_taken < 0.05" | bc -l) )); then + echo "RWF_NOWAIT time is within limits." +else + echo "RWF_NOWAIT took $time_taken seconds" +fi + +xfs_io -f -d -c "pread -v 0 2M" $testdir/f1 | _filter_xfs_io_unique + +# success, all done +status=0 +exit diff --git a/tests/generic/470.out b/tests/generic/470.out new file mode 100644 index 00000000..73a210b4 --- /dev/null +++ b/tests/generic/470.out @@ -0,0 +1,9 @@ +QA output created by 470 +pwrite: Resource temporarily unavailable +wrote 134217728/134217728 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +RWF_NOWAIT time is within limits. +00000000: cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd cd ................ +* +read 2097152/2097152 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) diff --git a/tests/generic/group b/tests/generic/group index 6c3bb03a..11ccfb01 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -472,3 +472,4 @@ 467 auto quick exportfs 468 shutdown auto quick metadata 469 auto quick +470 auto quick