From patchwork Mon Jan 15 04:27:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 10163045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24AEE601C0 for ; Mon, 15 Jan 2018 04:27:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22CBC286A3 for ; Mon, 15 Jan 2018 04:27:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1721F289FD; Mon, 15 Jan 2018 04:27:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 901A9286A3 for ; Mon, 15 Jan 2018 04:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbeAOE1h (ORCPT ); Sun, 14 Jan 2018 23:27:37 -0500 Received: from victor.provo.novell.com ([137.65.250.26]:38770 "EHLO prv3-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbeAOE1g (ORCPT ); Sun, 14 Jan 2018 23:27:36 -0500 Received: from adam-pc.lan (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by prv3-mh.provo.novell.com with ESMTP (NOT encrypted); Sun, 14 Jan 2018 21:27:25 -0700 From: Qu Wenruo To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH] btrfs-progs: fsck: Continue check even if we find space cache problem Date: Mon, 15 Jan 2018 12:27:22 +0800 Message-Id: <20180115042722.25435-1-wqu@suse.com> X-Mailer: git-send-email 2.15.1 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Space cache itself is not a fatal part of btrfs (especially for v1 space cache), and if we find something wrong it can be caused by other more serious problem. So continue to check more important trees even we found something wrong in free space cache. Signed-off-by: Qu Wenruo --- cmds-check.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmds-check.c b/cmds-check.c index 7fc30da83ea1..6083ac0dd032 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -15000,7 +15000,10 @@ int cmd_check(int argc, char **argv) error("errors found in free space tree"); else error("errors found in free space cache"); - goto out; + /* + * Space cache problem is not fatal, and normally indicates more + * serious problem, so continue check to expose the cause. + */ } /*