From patchwork Fri Mar 16 02:55:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 10286101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7E75602BD for ; Fri, 16 Mar 2018 02:56:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D668428982 for ; Fri, 16 Mar 2018 02:56:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CAD5228C70; Fri, 16 Mar 2018 02:56:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78FA628982 for ; Fri, 16 Mar 2018 02:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932862AbeCPC4C (ORCPT ); Thu, 15 Mar 2018 22:56:02 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:45367 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932752AbeCPC4A (ORCPT ); Thu, 15 Mar 2018 22:56:00 -0400 Received: by mail-pf0-f196.google.com with SMTP id h19so3628818pfd.12; Thu, 15 Mar 2018 19:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HERgWLOjFNRFgQjrNMjNK8E1yLPI4g8sQevGExVzIy0=; b=qs9Jd2gqV6ouE5Vox+14TQ/jJW9fF9ZebYjBz63pSo/k38ZcuDEE0UFlelfg3LqEYG UEUPl8isIymDaCDpYSR1YKUdUG3+et0VVwh4cRHu9VASm87axGdIVB7gS6XmBbFYClYP aQxoCRubTSL6z+TtXqK8MEebxw18PA3a61e9N5IxB5KHveGD4TfKBPUhxvlvo3v22Dxt rUFdecf77cOBLdPK5Ks3O3cM3uq8UzdiA/YrdXL+bxE5/TBL0otaj8NG0pvIOtV2Szop VydgGLT03AbQzJIDTCmclZOyX+b2w5n8Ei+AGtfAgXx7CT41BG7Wpx9sJBM0tOHGxnL/ QCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HERgWLOjFNRFgQjrNMjNK8E1yLPI4g8sQevGExVzIy0=; b=SjvxwY0s/VIHreRK5BUyhHyYpnSyMMHGkKVY1xrD0m9XBcTFPB/Fqfi3qy58yhOX9e 3gE6FewR5ShT53PSJuP5E1EXSBg5VMvNFbeGxO566uTXpeiYcwwDaHRy9lBqURXFX9pF X55/2zWP0y8mskC5ynAE5WvXqkv8l/dZAM2mshG/zmYyj+7ugieYpjiw3sVz0j/Kmq3U M6OYo3KxtqLg7LuwzUKD5WVJcMp6Hvm/1zi8d+DblHmtOmNIqZh3EI4WjAFfzMB47soK NuZbbNduWJhXIO10KqgND2l/zft1qQWnPNtLsuZElQ7/Qi1PhMlVoZDH1Q2CP4gkgKlm oBmQ== X-Gm-Message-State: AElRT7EOhvc3tohnrk28ywR7jV7+EagfECEL9Di+PGVVlEHzgtW94Lbh 691zXGoq9Kj4fGCuhSUCFRc= X-Google-Smtp-Source: AG47ELuwjX07I/OGz7ilsefInHkgiwmTsuBjgEnJrK+DdpGZHaYcIMeWU47NeUg8nTcBeDBAulKG7g== X-Received: by 10.98.253.17 with SMTP id p17mr166197pfh.105.1521168959906; Thu, 15 Mar 2018 19:55:59 -0700 (PDT) Received: from localhost ([128.199.137.77]) by smtp.gmail.com with ESMTPSA id b73sm10405154pga.62.2018.03.15.19.55.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Mar 2018 19:55:59 -0700 (PDT) Date: Fri, 16 Mar 2018 10:55:54 +0800 From: Eryu Guan To: Vivek Goyal Cc: fstests@vger.kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, Miklos Szeredi Subject: Re: [PATCH V3] xfstest: overlay: Absolute redirect should be followed even if ancestor is opaque Message-ID: <20180316025554.GM30836@localhost.localdomain> References: <20180314131618.GA1001@redhat.com> <20180316025320.GL30836@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180316025320.GL30836@localhost.localdomain> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Mar 16, 2018 at 10:53:20AM +0800, Eryu Guan wrote: > > +# Create opaque parent with absolute redirect child in middle layer > > +mkdir $SCRATCH_MNT/pure > > +mv $SCRATCH_MNT/origin $SCRATCH_MNT/pure/redirect > > +$UMOUNT_PROG $SCRATCH_MNT > > +_overlay_scratch_mount_dirs $lowerdir2:$lowerdir $upperdir $workdir -o redirect_dir=on > > +mv $SCRATCH_MNT/pure/redirect $SCRATCH_MNT/redirect > > I think we'd better do a "ls $SCRATCH_MNT/redirect/" here too, right > after the rename and before mount cycle, to make sure 'foo' is there as > well. I can add it on commit (and change the .out file too) if this > change looks OK to you. Something like this: git a/tests/overlay/057 b/tests/overlay/057 index 10b46bfa8cff..d54024e98bcd 100644 Thanks, Eryu --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/tests/overlay/057 +++ b/tests/overlay/057 @@ -86,6 +86,8 @@ mv $SCRATCH_MNT/origin $SCRATCH_MNT/pure/redirect $UMOUNT_PROG $SCRATCH_MNT _overlay_scratch_mount_dirs $lowerdir2:$lowerdir $upperdir $workdir -o redirect_dir=on mv $SCRATCH_MNT/pure/redirect $SCRATCH_MNT/redirect +# Verify that redirects are followed +ls $SCRATCH_MNT/redirect/ # Verify that redirects are followed after mount cycle $UMOUNT_PROG $SCRATCH_MNT diff --git a/tests/overlay/057.out b/tests/overlay/057.out index 750830212460..b3b4017d32ae 100644 --- a/tests/overlay/057.out +++ b/tests/overlay/057.out @@ -1,2 +1,3 @@ QA output created by 057 foo +foo