diff mbox

[xfstests-bld] test-appliance: fix use of undefined variable in gen_results_summary

Message ID 20180402171413.63324-1-ebiggers@google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Biggers April 2, 2018, 5:14 p.m. UTC
This fixes the following Python error when no tests were run:

    Traceback (most recent call last):
      File "/usr/local/bin/gen_results_summary", line 22, in <module>
	main()
      File "/usr/local/bin/gen_results_summary", line 19, in main
	sys.exit('No results file found in ' + results_dir)
    NameError: global name 'results_dir' is not defined

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 .../test-appliance/files/usr/local/bin/gen_results_summary      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Theodore Ts'o April 2, 2018, 6:56 p.m. UTC | #1
On Mon, Apr 02, 2018 at 10:14:13AM -0700, Eric Biggers wrote:
> This fixes the following Python error when no tests were run:
> 
>     Traceback (most recent call last):
>       File "/usr/local/bin/gen_results_summary", line 22, in <module>
> 	main()
>       File "/usr/local/bin/gen_results_summary", line 19, in main
> 	sys.exit('No results file found in ' + results_dir)
>     NameError: global name 'results_dir' is not defined
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary b/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
index be4401e..57c4a08 100755
--- a/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
+++ b/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
@@ -16,7 +16,7 @@  def main():
 
     if gen_results_summary(args.results_dir, args.output_file,
                            args.merge_file, args.verbose) == 0:
-        sys.exit('No results file found in ' + results_dir)
+        sys.exit('No results file found in ' + args.results_dir)
 
 if __name__ == "__main__":
     main()