From patchwork Sat Apr 28 14:59:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 10370279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BB2A60116 for ; Sat, 28 Apr 2018 14:59:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1751529237 for ; Sat, 28 Apr 2018 14:59:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B2AD29239; Sat, 28 Apr 2018 14:59:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A8AB29237 for ; Sat, 28 Apr 2018 14:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbeD1O7l (ORCPT ); Sat, 28 Apr 2018 10:59:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:60822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbeD1O7k (ORCPT ); Sat, 28 Apr 2018 10:59:40 -0400 Received: from tleilax.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDEF421A94; Sat, 28 Apr 2018 14:59:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDEF421A94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jlayton@kernel.org From: Jeff Layton To: fstests@vger.kernel.org, eguan@redhat.com Cc: willy@infradead.org, andres@anarazel.de, david@fromorbit.com, amir73il@gmail.com Subject: [PATCH v2] generic: test for seeing unseen fsync errors on newly open files Date: Sat, 28 Apr 2018 10:59:37 -0400 Message-Id: <20180428145937.6804-1-jlayton@kernel.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180427163833.21882-1-jlayton@kernel.org> References: <20180427163833.21882-1-jlayton@kernel.org> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff Layton This adds a regression test for the following kernel patch: errseq: Always report a writeback error once This is motivated by some rather odd behavior done by the PostgreSQL project. The main database writers will offload the fsync calls to a separate process, which can open files after a writeback error has already occurred. This used to work with older kernels that reported the error to only one fd, but with the errseq_t changes we lost the ability to see errors that occurred before the open. The above patch restores that behavior. Signed-off-by: Jeff Layton Reviewed-by: Amir Goldstein --- tests/generic/999 | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/999.out | 5 +++ tests/generic/group | 1 + 3 files changed, 105 insertions(+) create mode 100755 tests/generic/999 create mode 100644 tests/generic/999.out diff --git a/tests/generic/999 b/tests/generic/999 new file mode 100755 index 000000000000..081409f16100 --- /dev/null +++ b/tests/generic/999 @@ -0,0 +1,99 @@ +#! /bin/bash +# FS QA Test No. XXX +# +# Open a file several times, write to it, fsync on all fds and make sure that +# they all return 0. Change the device to start throwing errors. Write again +# on all fds and fsync on all fds. Ensure that we get errors on all of them. +# Then fsync on all one last time and verify that all return 0. +# +#----------------------------------------------------------------------- +# Copyright (c) 2018, Jeff Layton +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -rf $tmp.* $testdir + _dmerror_cleanup +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmerror + +# real QA test starts here +_supported_os Linux +_require_scratch +# This test uses "dm" without taking into account the data could be on +# realtime subvolume, thus the test will fail with rtinherit=1 +_require_no_rtinherit + +_require_dm_target error +_require_test_program fsync-open-after-err +_require_test_program dmerror + +rm -f $seqres.full + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_dmerror_init +_dmerror_mount + +datalen=65536 +_require_fs_space $SCRATCH_MNT $datalen + +# use fd 5 to hold file open +testfile=$SCRATCH_MNT/fsync-open-after-err +exec 5>$testfile + +# write some data to file and fsync it out +$XFS_IO_PROG -c "pwrite -q 0 $datalen" -c fsync $testfile + +# flip device to non-working mode +_dmerror_load_error_table + +# rewrite the data, call sync to ensure it's written back w/o scraping error +$XFS_IO_PROG -c "pwrite -q 0 $datalen" -c sync $testfile + +# heal the device error +_dmerror_load_working_table + +# open again and call fsync +echo "The following fsync should fail with EIO:" +$XFS_IO_PROG -c fsync $testfile +echo "done" + +# close file +exec 5>&- + +# success, all done +_dmerror_unmount +_dmerror_cleanup + +# fs may be corrupt after this -- attempt to repair it +_repair_scratch_fs >> $seqres.full +status=0 +exit diff --git a/tests/generic/999.out b/tests/generic/999.out new file mode 100644 index 000000000000..38d2d7f6495f --- /dev/null +++ b/tests/generic/999.out @@ -0,0 +1,5 @@ +QA output created by 999 +Format and mount +The following fsync should fail with EIO: +fsync: Input/output error +done diff --git a/tests/generic/group b/tests/generic/group index ea8e51b35e79..48f491a5c32b 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -486,3 +486,4 @@ 481 auto quick log metadata 482 auto metadata replay 483 auto quick log metadata +999 auto quick