From patchwork Fri May 4 15:12:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 10380843 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4E04D6038F for ; Fri, 4 May 2018 15:12:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40E89294D4 for ; Fri, 4 May 2018 15:12:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3384E294DC; Fri, 4 May 2018 15:12:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A49829410 for ; Fri, 4 May 2018 15:12:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbeEDPMh (ORCPT ); Fri, 4 May 2018 11:12:37 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38038 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeEDPMg (ORCPT ); Fri, 4 May 2018 11:12:36 -0400 Received: by mail-pf0-f195.google.com with SMTP id o76so17672199pfi.5 for ; Fri, 04 May 2018 08:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Hf8eyNUv1KUJ+D02f54dYjPrEMhaRUQTp9ZopGaiHh8=; b=RwIN9sMlYWUqHS8ZN6aK/jbjvUrXImywbu3Ob2JFBoqZLMRu9MJc7J0ViI0ONZCFAu hjvLJYJ7XOcrzZlWjE4qd7bZbhqkultpsEY8v1FIIb/rTTVlskRR3RC1UoRdHc9qwvrD TElflmt6WLfWn3MPSYAUVFH16hGtMSCbUXK40E1/nImuERBZDDh732bKiRmcIKE70D+x TSCcPBeo8k/zSjdsKUEKrDLv+NQEl+TvVpcWUNWYct2pQpfHhTtSfngxy75pjUbhXSYU J3tBqAlFzvTxmrO6sNUUjolDze6593a2L5q+UodrtfwvLTwpigiNRjnHNcrjeEwmT+b+ f6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Hf8eyNUv1KUJ+D02f54dYjPrEMhaRUQTp9ZopGaiHh8=; b=uLiP2FQ1c8JI1Kjb9hksSuN0KoidINHc9OtdHDtG6Kn4egeVjO0yGrlm25vtWx/LMO +I3b0B/0Y+MpqQDl08R59rN91w923oOXmyTMcIQJjMhX3/bsb48DJW6lMot+G2FIIyT0 vHX0Q7j57DePKWPOXY1h8mOKPj+PZ8dfEWD4s1v8HS7YU0uT4Gs0Zi+/97bTNtuxO2xR mT18zs4PlJFcEY1qjCMtjXe1ICY8m/87+LdgSg5+yg6mamJjnfm3sYx5traJRPbSYKeC l3jRrH6yN+8OR7a2RgzQg9nXh/PQp6qSAT9wpTUvE/idVxaKscejqHfAgPRBUIH+82AZ ROAg== X-Gm-Message-State: ALQs6tCOBQL38+MyTi2W1klHMvMBu/oQsU0+CJCnE7fVyi3Ol36Jtj03 FHs6zwM35IDb3TFDloo5YaH/wobd X-Google-Smtp-Source: AB8JxZpuwIi+lPVzjhp8rRg6LqnIfJu0NVqaMLMbR2HtOOErke6F11Dof7SOY09WWMO0GQJlXCjOpA== X-Received: by 10.98.254.17 with SMTP id z17mr27244469pfh.105.1525446756266; Fri, 04 May 2018 08:12:36 -0700 (PDT) Received: from localhost ([128.199.137.77]) by smtp.gmail.com with ESMTPSA id b6-v6sm24590403pgr.52.2018.05.04.08.12.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 May 2018 08:12:35 -0700 (PDT) Date: Fri, 4 May 2018 23:12:32 +0800 From: Eryu Guan To: Theodore Ts'o Cc: fstests@vger.kernel.org Subject: Re: [PATCH] Use the original install-sh file from SGI Message-ID: <20180504151232.GD8373@desktop> References: <20180503050728.25779-1-tytso@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180503050728.25779-1-tytso@mit.edu> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, May 03, 2018 at 01:07:28AM -0400, Theodore Ts'o wrote: > The install-sh file is much more efficient than the libtool version > (50% faster wall clock time; much more than that when running in a > qemu emulation build environment). There doesn't seem to be any real > need for the libtool version, so bring back the original install-sh > script. > > Signed-off-by: Theodore Ts'o > --- > > A very large amount of time when running "make install" in a build > chroot using qemu emulation, such as constructed by running "sudo > setup-buildchroot --arch-armhf" using the script found here[1] is in > running the install-sh provided by libtool, which is amazing bloated > and forks a crazy number of processes to do something very simple. > > As near as I can tell there is zero benefit in using the install-sh > provided by libtool, so restore the version that SGI originally used. This saves me 8s on 'make install' (23s -> 15s). But one problem with this is that after every 'make', install-sh is overwritten & modified by 'libtoolize -cfi', and git diff complains about the change. I think we could follow what xfsprogs does on this, that puts install-sh in include dir and copy it from there after it's overwritten by libtoolize. > > [1] https://github.com/tytso/xfstests-bld/blob/master/setup-buildchroot > > > .gitignore | 1 - > install-sh | 351 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 351 insertions(+), 1 deletion(-) > create mode 100755 install-sh > > diff --git a/.gitignore b/.gitignore > index 192ca35e..dfd3da7d 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -24,7 +24,6 @@ > > # libtool > /libtool > -/install-sh Then we don't need this change. So the patch would be like: diff --git a/include/install-sh b/include/install-sh new file mode 100755 index 000000000000..06d8aa9b6b9c --- /dev/null +++ b/include/install-sh This looks like a straightforward change, I can fix it on commit if the change looks sane to you. Thanks, Eryu --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Makefile b/Makefile index d97385f90142..1064984573be 100644 --- a/Makefile +++ b/Makefile @@ -80,6 +80,7 @@ endif configure: configure.ac libtoolize -cfi + cp include/install-sh . aclocal -I m4 autoheader autoconf