From patchwork Fri May 11 15:43:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 10394629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E888B60153 for ; Fri, 11 May 2018 15:43:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1369A28C7A for ; Fri, 11 May 2018 15:43:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07EE428F39; Fri, 11 May 2018 15:43:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DF3828C7A for ; Fri, 11 May 2018 15:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750876AbeEKPns (ORCPT ); Fri, 11 May 2018 11:43:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:58446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbeEKPns (ORCPT ); Fri, 11 May 2018 11:43:48 -0400 Received: from debian3.lan (bl12-226-64.dsl.telepac.pt [85.245.226.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F088321783; Fri, 11 May 2018 15:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526053427; bh=TpyrrmyCsTg9iUpjsveDkIOTGeH6sl5ORqBw5Uarjiw=; h=From:To:Cc:Subject:Date:From; b=tBO9PnRq4+GMArAhg8m9WsPmaWfoQClUlD0h0p3/hpXkAFpX8atTS+7mij4vjP0mF HtGJLnpx49F251XCmCXQtleY8p4b25nlXbX+GIWiI47EDeYVacAeikTiaRa67E7MJk adFnYs15LXKefUd3CL/URXadmbrz6S9nqMVTLAUk= From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH] fstests: generic test for fsync of file with xattrs Date: Fri, 11 May 2018 16:43:43 +0100 Message-Id: <20180511154343.12960-1-fdmanana@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Filipe Manana Test that xattrs are not lost after calling fsync multiple times with a filesystem commit in between the fsync calls. This test is motivated by a bug found in btrfs which is fixed by a patch for the linux kernel titled: Btrfs: fix xattr loss after power failure Signed-off-by: Filipe Manana --- tests/generic/487 | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/487.out | 11 +++++++ tests/generic/group | 1 + 3 files changed, 98 insertions(+) create mode 100755 tests/generic/487 create mode 100644 tests/generic/487.out diff --git a/tests/generic/487 b/tests/generic/487 new file mode 100755 index 00000000..328b5378 --- /dev/null +++ b/tests/generic/487 @@ -0,0 +1,86 @@ +#! /bin/bash +# FSQA Test No. 487 +# +# Test that xattrs are not lost after calling fsync multiple times with a +# filesystem commit in between the fsync calls. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2018 SUSE Linux Products GmbH. All Rights Reserved. +# Author: Filipe Manana +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + _cleanup_flakey + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmflakey +. ./common/attr + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch +_require_dm_target flakey +_require_attrs + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_require_metadata_journaling $SCRATCH_DEV +_init_flakey +_mount_flakey + +touch $SCRATCH_MNT/foobar +$SETFATTR_PROG -n user.xa1 -v qwerty $SCRATCH_MNT/foobar +$SETFATTR_PROG -n user.xa2 -v 'hello world' $SCRATCH_MNT/foobar +$SETFATTR_PROG -n user.xa3 -v test $SCRATCH_MNT/foobar +$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar + +# Call sync to commit all fileystem metadata. +sync + +$XFS_IO_PROG -c "pwrite -S 0xea 0 64K" \ + -c "fsync" \ + $SCRATCH_MNT/foobar >>$seqres.full + +# Simulate a power failure and mount the filesystem to check that the xattrs +# were not lost and neither was the data we wrote. +_flakey_drop_and_remount +echo "File xattrs after power failure:" +$GETFATTR_PROG --absolute-names --dump $SCRATCH_MNT/foobar | _filter_scratch +echo "File data after power failure:" +od -t x1 $SCRATCH_MNT/foobar + +_unmount_flakey +_cleanup_flakey + +status=0 +exit diff --git a/tests/generic/487.out b/tests/generic/487.out new file mode 100644 index 00000000..44a119f8 --- /dev/null +++ b/tests/generic/487.out @@ -0,0 +1,11 @@ +QA output created by 487 +File xattrs after power failure: +# file: SCRATCH_MNT/foobar +user.xa1="qwerty" +user.xa2="hello world" +user.xa3="test" + +File data after power failure: +0000000 ea ea ea ea ea ea ea ea ea ea ea ea ea ea ea ea +* +0200000 diff --git a/tests/generic/group b/tests/generic/group index 505383f7..c8f51ec2 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -489,3 +489,4 @@ 484 auto quick 485 auto quick insert 486 auto quick attr +487 auto quick attr