From patchwork Mon May 21 16:07:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10415867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 988196053B for ; Mon, 21 May 2018 16:07:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84F5F288CF for ; Mon, 21 May 2018 16:07:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77A61288E0; Mon, 21 May 2018 16:07:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3554F288CF for ; Mon, 21 May 2018 16:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbeEUQHv (ORCPT ); Mon, 21 May 2018 12:07:51 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:56756 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752148AbeEUQHv (ORCPT ); Mon, 21 May 2018 12:07:51 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4LG6OC5164257; Mon, 21 May 2018 16:07:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=nZrg2ZB6VJ5lGPZashTCB9nrnfvcSsE8L5ZoFUSb0fI=; b=krzz7byX5Z7Z/kGsUJqtlinxih0lJxd4hE5ZrJZ0fQd41WjsEy8MwJ8seojTAZU06hx8 Ybckk2C3SHGm9FNatKitPouNuNgCoTZu2x33VFoUwtcdx+AWdPsJm5m1U9vLW94AqJM9 v1LySaB+ur+7BmKHiJLVfHsk6F2JnpE/Xhi3eL9lCm8IwK7uFDSCYEDVecwq/s1eCPOu a6CUy3AkI55g+vhIJGTJaxbOjne5WPlVB0avgz+REEmOpMq9BPFSeEunPyCGi3YeSHGB 60jq9iGyWqyQOzZVPskYGJKPB6+DHq4qxjL6tKW82AoumU40Gn+NwT97vB9yK/jHR80X Lg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2j2ck9cw61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 May 2018 16:07:36 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w4LG7ZJH017338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 May 2018 16:07:36 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4LG7Zkf027132; Mon, 21 May 2018 16:07:35 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 May 2018 09:07:35 -0700 Date: Mon, 21 May 2018 09:07:34 -0700 From: "Darrick J. Wong" To: Eryu Guan Cc: zlang@redhat.com, fstests Subject: [PATCH] generic/475: fix confusing comment Message-ID: <20180521160734.GJ4910@magnolia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8900 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805210192 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong The comment about the dmerror switcheroo is hard to understand and wrong. Fix both problems by rewriting it. Signed-off-by: Darrick J. Wong --- tests/generic/475 | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/generic/475 b/tests/generic/475 index e31f1251..45072278 100755 --- a/tests/generic/475 +++ b/tests/generic/475 @@ -73,9 +73,11 @@ for i in $(seq 1 $((50 * TIME_FACTOR)) ); do # recovery sleep $((RANDOM % 3)) - # Loading error table without "--nolockfs" option. Because "--nolockfs" - # won't freeze fs, then some running I/Os may cause XFS to shutdown - # prematurely. That's not what we want to test. + # This test aims to simulate sudden disk failure, which means that we + # do not want to quiesce the filesystem or otherwise give it a chance + # to flush its logs. Therefore we want to call dmsetup with the + # --nolockfs parameter; to make this happen we must call the load + # error table helper *without* 'lockfs'. _dmerror_load_error_table ps -e | grep fsstress > /dev/null 2>&1