diff mbox

[5/6] xfs: abstract xfs_info into $XFS_INFO_PROG

Message ID 20180607113713.GA1103@desktop (mailing list archive)
State New, archived
Headers show

Commit Message

Eryu Guan June 7, 2018, 11:37 a.m. UTC 
On Tue, Jun 05, 2018 at 09:43:27AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Abstract calls to xfs_info into $XFS_INFO_PROG like we do for all other
> xfs utilities.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  common/attr      |    2 +-
>  common/config    |    1 +
>  common/populate  |   18 +++++++++---------
>  common/rc        |    2 +-

Better to make xfs_info mandatory too when testing xfs, so I did the
below diff on commit


Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Darrick J. Wong June 7, 2018, 3:03 p.m. UTC | #1 
On Thu, Jun 07, 2018 at 07:37:13PM +0800, Eryu Guan wrote:
> On Tue, Jun 05, 2018 at 09:43:27AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Abstract calls to xfs_info into $XFS_INFO_PROG like we do for all other
> > xfs utilities.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  common/attr      |    2 +-
> >  common/config    |    1 +
> >  common/populate  |   18 +++++++++---------
> >  common/rc        |    2 +-
> 
> Better to make xfs_info mandatory too when testing xfs, so I did the
> below diff on commit

Ok, thank you for making the change on the way in. :)

--D

> diff --git a/common/rc b/common/rc
> index f04c9ea2fd89..9d6665b6c4d7 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -136,6 +136,7 @@ case "$FSTYP" in
>          [ "$XFS_REPAIR_PROG" = "" ] && _fatal "xfs_repair not found"
>          [ "$XFS_DB_PROG" = "" ] && _fatal "xfs_db not found"
>          [ "$MKFS_XFS_PROG" = "" ] && _fatal "mkfs_xfs not found"
> +        [ "$XFS_INFO_PROG" = "" ] && _fatal "xfs_info not found"
> 
>          . ./common/xfs
>          ;;
> 
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/common/rc b/common/rc
index f04c9ea2fd89..9d6665b6c4d7 100644
--- a/common/rc
+++ b/common/rc
@@ -136,6 +136,7 @@  case "$FSTYP" in
         [ "$XFS_REPAIR_PROG" = "" ] && _fatal "xfs_repair not found"
         [ "$XFS_DB_PROG" = "" ] && _fatal "xfs_db not found"
         [ "$MKFS_XFS_PROG" = "" ] && _fatal "mkfs_xfs not found"
+        [ "$XFS_INFO_PROG" = "" ] && _fatal "xfs_info not found"

         . ./common/xfs
         ;;