From patchwork Mon Jul 2 07:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lu Fengqi X-Patchwork-Id: 10500543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6CD4460532 for ; Mon, 2 Jul 2018 07:00:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C9232879E for ; Mon, 2 Jul 2018 07:00:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50BCF287B6; Mon, 2 Jul 2018 07:00:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8126E2879E for ; Mon, 2 Jul 2018 07:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932668AbeGBHAS (ORCPT ); Mon, 2 Jul 2018 03:00:18 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:65156 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752701AbeGBHAO (ORCPT ); Mon, 2 Jul 2018 03:00:14 -0400 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="41729425" Received: from localhost (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 02 Jul 2018 15:00:12 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 6A2C24B43D4F; Mon, 2 Jul 2018 15:00:06 +0800 (CST) Received: from fnst.localdomain (10.167.226.155) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.399.0; Mon, 2 Jul 2018 15:00:11 +0800 From: Lu Fengqi To: CC: , , Subject: [PATCH] build: fix possibly undefined macro: AC_PACKAGE_NEED_GETXATTR_LIBATTR Date: Mon, 2 Jul 2018 15:00:01 +0800 Message-ID: <20180702070001.1973-1-lufq.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-Originating-IP: [10.167.226.155] X-yoursite-MailScanner-ID: 6A2C24B43D4F.AB6CF X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: lufq.fnst@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because the macro AC_PACKAGE_NEED_GETXATTR_LIBATTR was removed by the following commit specified by fixes tag, we also need remove AC_PACKAGE_NEED_GETXATTR_LIBATTR from configure.ac. In addition, the libattr will not be set, after the macro was be removed. This cause gcc can't link the libattr for fsstress correctly. The macro AC_PACKAGE_NEED_ATTRGET_LIBATTR has been obsoleted, so change it to AC_PACKAGE_NEED_ATTRSET_LIBATTR and add it to configure.ac. It can help me check libattr and set libattr variable. Fixes: 42b851446ff1 ("build: remove check") Reported-by: Zorro Lang Signed-off-by: Lu Fengqi Tested-by: Darrick J. Wong --- Hi, Eryu I apologize for the previous patch about the build infrastructure that caused the master branch to not be compiled. Spoiler: Regarding the following deprecated functions, I want to replace them with the glibc version. And, I will carefully confirm the correctness before send patches. Any suggestions? fsstress.c:762:2: warning: 'attr_list' is deprecated: Use listxattr or llistxattr instead [-Wdeprecated-declarations] fsstress.c:781:2: warning: 'attr_remove' is deprecated: Use removexattr or lremovexattr instead [-Wdeprecated-declarations] fsstress.c:801:2: warning: 'attr_set' is deprecated: Use setxattr or lsetxattr instead [-Wdeprecated-declarations] configure.ac | 2 +- m4/package_attrdev.m4 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 63ea032dc564..aede4f59a060 100644 --- a/configure.ac +++ b/configure.ac @@ -53,7 +53,7 @@ AC_PACKAGE_NEED_XFS_HANDLE_H AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE AC_PACKAGE_NEED_ATTRIBUTES_H AC_PACKAGE_WANT_ATTRLIST_LIBATTR -AC_PACKAGE_NEED_GETXATTR_LIBATTR +AC_PACKAGE_NEED_ATTRSET_LIBATTR AC_PACKAGE_NEED_SYS_ACL_H AC_PACKAGE_NEED_ACL_LIBACL_H diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4 index 9a82f241de3a..d994cfc23c25 100644 --- a/m4/package_attrdev.m4 +++ b/m4/package_attrdev.m4 @@ -26,8 +26,8 @@ AC_DEFUN([AC_PACKAGE_WANT_ATTRLIST_LIBATTR], AC_SUBST(have_attr_list) ]) -AC_DEFUN([AC_PACKAGE_NEED_ATTRGET_LIBATTR], - [ AC_CHECK_LIB(attr, attr_get,, [ +AC_DEFUN([AC_PACKAGE_NEED_ATTRSET_LIBATTR], + [ AC_CHECK_LIB(attr, attr_set,, [ echo echo 'FATAL ERROR: could not find a valid Extended Attributes library.' echo 'Install the extended attributes (attr) development package.'