From patchwork Mon Oct 8 10:13:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 10630339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8994315E2 for ; Mon, 8 Oct 2018 10:13:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 73D9E27528 for ; Mon, 8 Oct 2018 10:13:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EAB22787C; Mon, 8 Oct 2018 10:13:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D610F26E96 for ; Mon, 8 Oct 2018 10:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbeJHRYQ (ORCPT ); Mon, 8 Oct 2018 13:24:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:50274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbeJHRYP (ORCPT ); Mon, 8 Oct 2018 13:24:15 -0400 Received: from localhost.localdomain (bl8-197-74.dsl.telepac.pt [85.241.197.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D18F82064E; Mon, 8 Oct 2018 10:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538993597; bh=WK6xvagR+mqdH6iTEn9wW5/vzdMJv3mTibgF8YQ2RyA=; h=From:To:Cc:Subject:Date:From; b=2JR1AWa5ZIC1n6O4fX2UJmN8vpJXfapCLx9hxR0g/CP385W3ZJ0YJSazIUjNXYWKc kNcZ3GxUssGSFUcvNyT1Kh0WOqI1qCxe3HAtfS3G8G8tqWGdmjP5wBu5ReZQw5nUZ+ a38A1Ld3CnA1Ox03jKp2HlMofdomg0+OXLeYMQBA= From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH] generic: test mounting filesystem after fsync of a tmpfile Date: Mon, 8 Oct 2018 11:13:13 +0100 Message-Id: <20181008101313.17156-1-fdmanana@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Filipe Manana Test that if we fsync a tmpfile, without adding a hard link to it, and then power fail, we will be able to mount the filesystem without triggering any crashes, warnings or corruptions. This test is motivated by an issue in btrfs where this scenario triggered a warning (without any side effects). The following linux kernel patch fixes the issue in btrfs: "Btrfs: fix warning when replaying log after fsync of a tmpfile" Signed-off-by: Filipe Manana --- tests/generic/506 | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/506.out | 3 +++ tests/generic/group | 1 + 3 files changed, 62 insertions(+) create mode 100755 tests/generic/506 create mode 100644 tests/generic/506.out diff --git a/tests/generic/506 b/tests/generic/506 new file mode 100755 index 00000000..7d28d3b0 --- /dev/null +++ b/tests/generic/506 @@ -0,0 +1,58 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2018 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test No. 506 +# +# Test that if we fsync a tmpfile, without adding a hard link to it, and then +# power fail, we will be able to mount the filesystem without triggering any +# crashes, warnings or corruptions. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + _cleanup_flakey + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmflakey + +# real QA test starts here +_supported_fs generic +_supported_os Linux +_require_scratch +_require_xfs_io_command "-T" +_require_dm_target flakey + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_require_metadata_journaling $SCRATCH_DEV +_init_flakey +_mount_flakey + +# Create our tmpfile, write some data to it and fsync it. We want a power +# failure to happen after the fsync, so that we have an inode with a link +# count of 0 in our log/journal. +$XFS_IO_PROG -T \ + -c "pwrite -S 0xab 0 64K" \ + -c "fsync" \ + $SCRATCH_MNT | _filter_xfs_io + +# Simulate a power failure and mount the filesystem to check that it succeeds. +_flakey_drop_and_remount + +_unmount_flakey + +status=0 +exit diff --git a/tests/generic/506.out b/tests/generic/506.out new file mode 100644 index 00000000..f522e663 --- /dev/null +++ b/tests/generic/506.out @@ -0,0 +1,3 @@ +QA output created by 506 +wrote 65536/65536 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) diff --git a/tests/generic/group b/tests/generic/group index 4da0e188..2e2a6247 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -508,3 +508,4 @@ 503 auto quick dax punch collapse zero 504 auto quick locks 505 shutdown auto quick metadata +506 auto quick log