diff mbox series

generic: update group file to indicate generic/456 uses {collapse,zero}_range

Message ID 20181026115349.4241-1-tytso@mit.edu (mailing list archive)
State New, archived
Headers show
Series generic: update group file to indicate generic/456 uses {collapse,zero}_range | expand

Commit Message

Theodore Ts'o Oct. 26, 2018, 11:53 a.m. UTC
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bill O'Donnell Oct. 26, 2018, 2:40 p.m. UTC | #1
On Fri, Oct 26, 2018 at 07:53:49AM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index 28452732..8a21970e 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -458,7 +458,7 @@
>  453 auto quick dir
>  454 auto quick attr
>  455 auto log replay
> -456 auto quick metadata
> +456 auto quick metadata collapse zero
>  457 auto log replay clone
>  458 auto quick clone collapse zero
>  459 auto thin
> -- 
> 2.18.0.rc0
>
Filipe Manana Oct. 27, 2018, 9:22 a.m. UTC | #2
On Fri, Oct 26, 2018 at 12:53 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index 28452732..8a21970e 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -458,7 +458,7 @@
>  453 auto quick dir
>  454 auto quick attr
>  455 auto log replay
> -456 auto quick metadata
> +456 auto quick metadata collapse zero

Since it uses fallocate too, should also be in the 'prealloc' group.

Thanks.

>  457 auto log replay clone
>  458 auto quick clone collapse zero
>  459 auto thin
> --
> 2.18.0.rc0
>
Eryu Guan Oct. 28, 2018, 1:35 p.m. UTC | #3
On Sat, Oct 27, 2018 at 10:22:16AM +0100, Filipe Manana wrote:
> On Fri, Oct 26, 2018 at 12:53 PM Theodore Ts'o <tytso@mit.edu> wrote:
> >
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > ---
> >  tests/generic/group | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/generic/group b/tests/generic/group
> > index 28452732..8a21970e 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -458,7 +458,7 @@
> >  453 auto quick dir
> >  454 auto quick attr
> >  455 auto log replay
> > -456 auto quick metadata
> > +456 auto quick metadata collapse zero
> 
> Since it uses fallocate too, should also be in the 'prealloc' group.

I'll add it on commit, thanks for review!

Eryu

> 
> Thanks.
> 
> >  457 auto log replay clone
> >  458 auto quick clone collapse zero
> >  459 auto thin
> > --
> > 2.18.0.rc0
> >
> 
> 
> -- 
> Filipe David Manana,
> 
> “Whether you think you can, or you think you can't — you're right.”
diff mbox series

Patch

diff --git a/tests/generic/group b/tests/generic/group
index 28452732..8a21970e 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -458,7 +458,7 @@ 
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin