xfs/500: fix review comments

Commit Message

Darrick J. Wong Feb. 19, 2019, 5:29 a.m. UTC

From: Darrick J. Wong <[e-mail]>

Fix some problems detecting reflink support in the test.

Signed-off-by: Darrick J. Wong <[e-mail]>
---
 tests/xfs/500   |    5 ++---
 tests/xfs/group |    2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

Patch

diff --git a/tests/xfs/500 b/tests/xfs/500
index 7a965c69..370c78ec 100755
--- a/tests/xfs/500
+++ b/tests/xfs/500
@@ -36,10 +36,9 @@  _scratch_mkfs -d extszinherit=8388608 >> $seqres.full 2>&1
 test $? -eq 1 || echo "should have failed extszinherit"
 
 # Try cow extent size hint if supported
-$MKFS_XFS_PROG -N -f $SCRATCH_DEV > $tmp.mkfs
-if grep -q 'reflink=' $tmp.mkfs ; then
+if _scratch_mkfs_xfs_supported -m crc=1,reflink=1 >> $seqres.full 2>&1; then
 	echo cowextsize >> $seqres.full
-	_scratch_mkfs -m reflink=1 -d cowextsize=8388608 >> $seqres.full 2>&1
+	_scratch_mkfs -m reflink=1,crc=1 -d cowextsize=8388608 >> $seqres.full 2>&1
 	test $? -eq 1 || echo "should have failed cowextsize"
 fi
 
diff --git a/tests/xfs/group b/tests/xfs/group
index 76b8a413..0047fb5c 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -497,6 +497,6 @@ 
 497 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 498 dangerous_fuzzers dangerous_norepair
 499 auto quick
-500 auto quick mkfs
+500 auto quick mkfs prealloc mkfs
 501 auto quick unlink
 502 auto quick unlink