From patchwork Tue Feb 19 05:29:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10819191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B144922 for ; Tue, 19 Feb 2019 05:29:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06F392B34B for ; Tue, 19 Feb 2019 05:29:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAF4F2B351; Tue, 19 Feb 2019 05:29:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C5592B334 for ; Tue, 19 Feb 2019 05:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725805AbfBSF3L (ORCPT ); Tue, 19 Feb 2019 00:29:11 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:56602 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfBSF3K (ORCPT ); Tue, 19 Feb 2019 00:29:10 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1J5Sh1w104325; Tue, 19 Feb 2019 05:29:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=gBEhsIoVNyw0bcfEgY1Fr1UNpJ7yg0IRB71L03LxtHc=; b=f+ZKgcJY5DNWMCw1OVQLE1toT8wskqLkMdnzy64G4/3GTrvIsRSAIMneyE/9qdGopqIh lRRzVQLSURkSvd0o2XHWmam5F7dIew0uG9eiMQUdMPcpFMIpk0e3rLLXtfG0lF71+d8/ QKePaTnoNJ69rqUKaodXkCpz6QGfqpj4Kxo1nTFScqA6eMp3nvQcBTPUIruPClmsxKsv 15useroU/E6nvx9vyF9QJ0Yenid9jhc18VBQzA90wFCDAdso9k7luCJ2YhQYmfUQlZmv lMuaJvURplohkDFCTPfzjV4R6WdH1EoJEvLUKTqCHpdjR2yDSxYMOwVDXUAB+lXvu1tw Pg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qp9xts0pt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 05:29:07 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1J5T6DX016927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 05:29:06 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1J5T6gN025662; Tue, 19 Feb 2019 05:29:06 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Feb 2019 21:29:06 -0800 Date: Mon, 18 Feb 2019 21:29:05 -0800 From: "Darrick J. Wong" To: Eryu Guan Cc: fstests , xfs , Dave Chinner Subject: [PATCH] xfs/500: fix review comments Message-ID: <20190219052905.GH6477@magnolia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902190042 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Fix some problems detecting reflink support in the test. Signed-off-by: Darrick J. Wong --- tests/xfs/500 | 5 ++--- tests/xfs/group | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/xfs/500 b/tests/xfs/500 index 7a965c69..370c78ec 100755 --- a/tests/xfs/500 +++ b/tests/xfs/500 @@ -36,10 +36,9 @@ _scratch_mkfs -d extszinherit=8388608 >> $seqres.full 2>&1 test $? -eq 1 || echo "should have failed extszinherit" # Try cow extent size hint if supported -$MKFS_XFS_PROG -N -f $SCRATCH_DEV > $tmp.mkfs -if grep -q 'reflink=' $tmp.mkfs ; then +if _scratch_mkfs_xfs_supported -m crc=1,reflink=1 >> $seqres.full 2>&1; then echo cowextsize >> $seqres.full - _scratch_mkfs -m reflink=1 -d cowextsize=8388608 >> $seqres.full 2>&1 + _scratch_mkfs -m reflink=1,crc=1 -d cowextsize=8388608 >> $seqres.full 2>&1 test $? -eq 1 || echo "should have failed cowextsize" fi diff --git a/tests/xfs/group b/tests/xfs/group index 76b8a413..0047fb5c 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -497,6 +497,6 @@ 497 dangerous_fuzzers dangerous_scrub dangerous_online_repair 498 dangerous_fuzzers dangerous_norepair 499 auto quick -500 auto quick mkfs +500 auto quick mkfs prealloc mkfs 501 auto quick unlink 502 auto quick unlink