From patchwork Tue May 21 08:28:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Henriques X-Patchwork-Id: 10953165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3DDF0924 for ; Tue, 21 May 2019 08:28:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DBED288E1 for ; Tue, 21 May 2019 08:28:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 21B472893A; Tue, 21 May 2019 08:28:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8156288E1 for ; Tue, 21 May 2019 08:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726344AbfEUI2k (ORCPT ); Tue, 21 May 2019 04:28:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:52700 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726138AbfEUI2k (ORCPT ); Tue, 21 May 2019 04:28:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1661BAF02; Tue, 21 May 2019 08:28:39 +0000 (UTC) From: Luis Henriques To: "Darrick J. Wong" , Nikolay Borisov Cc: fstests@vger.kernel.org, Luis Henriques Subject: [PATCH v2] src/attr_replace_test: limit size of extended attribute value Date: Tue, 21 May 2019 09:28:36 +0100 Message-Id: <20190521082836.4482-1-lhenriques@suse.com> In-Reply-To: References: MIME-Version: 1.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The maximum size for extended attribute values is 65536 (XATTR_SIZE_MAX). Since there are filesystems that can set blksize to really big values (CephFS for example has a default of 4M), it's easy to have this test failing with fsetxattr returning -E2BIG. Cc: Darrick J. Wong Signed-off-by: Luis Henriques Reviewed-by: Darrick J. Wong --- src/attr_replace_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/attr_replace_test.c b/src/attr_replace_test.c index 0720bfdc18ab..cca8dcf8ff60 100644 --- a/src/attr_replace_test.c +++ b/src/attr_replace_test.c @@ -9,6 +9,8 @@ #include #include #include +#include +#include #define die() do { perror(""); \ fprintf(stderr, "error at line %d\n", __LINE__); \ @@ -44,6 +46,7 @@ int main(int argc, char *argv[]) size = sbuf.st_blksize * 3 / 4; if (!size) fail("Invalid st_blksize(%ld)\n", sbuf.st_blksize); + size = MIN(size, XATTR_SIZE_MAX); value = malloc(size); if (!value) fail("Failed to allocate memory\n");