From patchwork Thu Aug 15 18:26:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 11096247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1AB7417E2 for ; Thu, 15 Aug 2019 18:27:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DBBC28662 for ; Thu, 15 Aug 2019 18:27:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0230728722; Thu, 15 Aug 2019 18:27:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71C092871A for ; Thu, 15 Aug 2019 18:27:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731965AbfHOS1D (ORCPT ); Thu, 15 Aug 2019 14:27:03 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:44536 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730151AbfHOS1D (ORCPT ); Thu, 15 Aug 2019 14:27:03 -0400 Received: by mail-qt1-f196.google.com with SMTP id 44so3307903qtg.11 for ; Thu, 15 Aug 2019 11:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aOubM/Y9XONiB9v1608aZPxTWneDeIuizdk2L2LgSg8=; b=XJynwpJJbsJvejMe0VyFcGZZxPTzmhNv9Df14BcjQaN3aPkLQIwwDO5OC3Z0DvzBlH yKc1tfDapx7i+BN7Sbwv0ODqfUIcRk1G0NUQdTnfka3+SZl/31Mb+SNGhYJSM5TUKMOx j/DvlQl8I1eZlKFgLL6F8+Nco/aheJD0xvq4IjGE+EM5fb3eGm/FR86QgrixeFlSO0GX pgVRvNzWDReXybwneoZQ9/AKEBPHZfyzgeh66rfeEY1ORk7Ru5PPvgDcy1qhtX4cZl3U 5R3F4rZ1kuYq8QMB/FdfH9qWtX3JpvOTprAFVrDcDD17r0+I/k0ESOQ4PnCrKgoqnbZa 2eVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aOubM/Y9XONiB9v1608aZPxTWneDeIuizdk2L2LgSg8=; b=P4lRyBalR6nfcBVcK6bYIyEJRShKukVSnv/0/Qler/0q9YnZI99CtUgFBaiBl7A+Ek gAiesnvLTyMegvt9sZQp+sJqJhucQwVXdWrbvlmMsKZ1SE75l8O1LLW1IqDDkjDA1jFl QzgqI09EAhYT+Ivp19PtGhigUnExZ/h2hSQ1K0KYSCAOZ7imIhU/s3wSaEMvUfXcHezo rLFOfC5CzpY6X6MhUrnPPtEA94VC4J2W2N07bwnNUv3Fttp+yGmmWfmiFJHaMOKF9IIA kvoiXQve2zZkaEAHC6Z6QM39cBc7Ksk5BpT5WSzB5xuXbl2zPGlMYz5/ePA+E5uV+3xW Pmdg== X-Gm-Message-State: APjAAAW3vrFNQtYMwbyG9c5MLpq1Hyg55t1lfRb88NM8T4fQjoN85EcP Et+MoEEDIbfja+oSyrrb1RJ3kFtKt9Bj6g== X-Google-Smtp-Source: APXvYqyx1qWSuxMCsU1PG4NrJOguKooTyh9oFhBHXAdPIRxLyKlmYAuB7DCo/KYTO7FNTX9Fhr7MSg== X-Received: by 2002:ac8:2646:: with SMTP id v6mr5174548qtv.205.1565893621734; Thu, 15 Aug 2019 11:27:01 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id d9sm1802775qke.136.2019.08.15.11.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 11:27:01 -0700 (PDT) From: Josef Bacik To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH] fstests: generic/500 doesn't work for btrfs Date: Thu, 15 Aug 2019 14:26:59 -0400 Message-Id: <20190815182659.27875-1-josef@toxicpanda.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Btrfs does COW, so when we unlink the file we need to update metadata and write it to a new location, which we can't do because the thinp is full. This results in an EIO during a metadata write, which makes us flip read only, thus making it impossible to fstrim the fs. Just make it so we skip this test for btrfs. Signed-off-by: Josef Bacik Reviewed-by: Darrick J. Wong --- tests/generic/500 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/generic/500 b/tests/generic/500 index 201d8b9f..5cd7126f 100755 --- a/tests/generic/500 +++ b/tests/generic/500 @@ -49,6 +49,12 @@ _supported_os Linux _require_scratch_nocheck _require_dm_target thin-pool +# The unlink below will result in new metadata blocks for btrfs because of CoW, +# and since we've filled the thinp device it'll return EIO, which will make +# btrfs flip read only, making it fail this test when it just won't work right +# for us in the first place. +test $FSTYP == "btrfs" && _notrun "btrfs doesn't work that way lol" + # Require underlying device support discard _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount