diff mbox series

xfs/191-input-validation:Fix issue that the test takes too long

Message ID 20191127104131.112533-1-lubaihua0331@gmail.com (mailing list archive)
State New, archived
Headers show
Series xfs/191-input-validation:Fix issue that the test takes too long | expand

Commit Message

Baihua Lu Nov. 27, 2019, 10:41 a.m. UTC
After this test is passed, checking filesystems will execute. Then
xfs_logprint will be failed and xfs_repair will take a long time because
there is not really creating the file system in this test and wipefs
executes before this test. So there is no need checking filesystems.

Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
 tests/xfs/191-input-validation | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Nov. 27, 2019, 4:31 p.m. UTC | #1
On Wed, Nov 27, 2019 at 02:41:31AM -0800, Baihua Lu wrote:
> After this test is passed, checking filesystems will execute. Then
> xfs_logprint will be failed and xfs_repair will take a long time because
> there is not really creating the file system in this test and wipefs
> executes before this test. So there is no need checking filesystems.
> 
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>

Ok, looks fine.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/xfs/191-input-validation | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
>  # Modify as appropriate.
>  _supported_fs xfs
>  _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
>  _require_xfs_mkfs_validation
>  
>  
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
index b6658015..db427349 100755
--- a/tests/xfs/191-input-validation
+++ b/tests/xfs/191-input-validation
@@ -31,7 +31,7 @@  _cleanup()
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os Linux
-_require_scratch
+_require_scratch_nocheck
 _require_xfs_mkfs_validation