| Message ID | 20200615105236.32198-1-lczerner@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | 270: wait for fsstress processes to be killed | expand |
diff --git a/tests/generic/270 b/tests/generic/270 index 5092ffa4..55779f5e 100755 --- a/tests/generic/270 +++ b/tests/generic/270 @@ -38,7 +38,6 @@ _workout() $SETCAP_PROG cap_chown=epi $tmp.fsstress.bin (su $qa_user -c "$tmp.fsstress.bin $args" &) > /dev/null 2>&1 - pid=$! echo "Run dd writers in parallel" for ((i=0; i < num_iterations; i++)) @@ -50,8 +49,7 @@ _workout() sleep $enospc_time done - $KILLALL_PROG $tmp.fsstress.bin - wait $pid + $KILLALL_PROG -w $tmp.fsstress.bin } # real QA test starts here
Currently wait will do nothing, because $pid is empty due to the fact that the command was ran on the background in a separate shell so we never got the $! set. This is causing unexpected test failures especially under low memory due to the fact that the fsstress is still running when we are checking and comparing quota usage. Fix it by using -w argument for killall that will wait for all processes to actually die before it exits. Signed-off-by: Lukas Czerner <lczerner@redhat.com> --- tests/generic/270 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)