diff mbox series

generic/603: don't run on XFS v4 filesystems

Message ID 20200729025141.GW7600@magnolia (mailing list archive)
State New, archived
Headers show
Series generic/603: don't run on XFS v4 filesystems | expand

Commit Message

Darrick J. Wong July 29, 2020, 2:51 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

XFS filesystems require V5 format to support all three quota types at
the same time, so skip the test if we're testing XFS older than that.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/generic/603 |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Zorro Lang July 29, 2020, 4:53 a.m. UTC | #1
On Tue, Jul 28, 2020 at 07:51:41PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> XFS filesystems require V5 format to support all three quota types at
> the same time, so skip the test if we're testing XFS older than that.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Thanks for fixing it!
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/603 |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/603 b/tests/generic/603
> index 54deaf13..fc3df6e5 100755
> --- a/tests/generic/603
> +++ b/tests/generic/603
> @@ -149,6 +149,10 @@ test_grace()
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> +# xfs requires v5 format to support all three quota types at the same time
> +if [ "$FSTYP" = "xfs" ]; then
> +	_require_scratch_xfs_crc
> +fi
>  _require_setquota_project
>  _require_quota
>  _require_user
>
diff mbox series

Patch

diff --git a/tests/generic/603 b/tests/generic/603
index 54deaf13..fc3df6e5 100755
--- a/tests/generic/603
+++ b/tests/generic/603
@@ -149,6 +149,10 @@  test_grace()
 _supported_fs generic
 _supported_os Linux
 _require_scratch
+# xfs requires v5 format to support all three quota types at the same time
+if [ "$FSTYP" = "xfs" ]; then
+	_require_scratch_xfs_crc
+fi
 _require_setquota_project
 _require_quota
 _require_user