| Message ID | 20200911021813.o6vtueabupevfgab@xzhoux.usersys.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] overlay/073: test with nfs_export being off | expand |
On Fri, Sep 11, 2020 at 5:18 AM Murphy Zhou <jencce.kernel@gmail.com> wrote: > > When nfs_export is enabled, the link count of upper dir > objects are more then the expected number in this testcase. > Because extra index entries are linked to upper inodes. > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> Reviewed-by: Amir Goldstein <amir73il@gmail.com> > --- > tests/overlay/073 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/overlay/073 b/tests/overlay/073 > index 37860c92..c5deccc6 100755 > --- a/tests/overlay/073 > +++ b/tests/overlay/073 > @@ -99,7 +99,9 @@ run_test_case() > { > _scratch_mkfs > make_lower_files ${1} > - _scratch_mount -o "index=on" > + # There will be extra hard links with nfs_export enabled which > + # is expected. Turn it off explicitly to avoid the false alarm. > + _scratch_mount -o "index=on,nfs_export=off" > make_whiteout_files > check_whiteout_files ${1} ${2} > _scratch_unmount > -- > 2.20.1 >
Ping on this one. On Fri, Sep 11, 2020 at 10:18:13AM +0800, Murphy Zhou wrote: > When nfs_export is enabled, the link count of upper dir > objects are more then the expected number in this testcase. > Because extra index entries are linked to upper inodes. > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > --- > tests/overlay/073 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/overlay/073 b/tests/overlay/073 > index 37860c92..c5deccc6 100755 > --- a/tests/overlay/073 > +++ b/tests/overlay/073 > @@ -99,7 +99,9 @@ run_test_case() > { > _scratch_mkfs > make_lower_files ${1} > - _scratch_mount -o "index=on" > + # There will be extra hard links with nfs_export enabled which > + # is expected. Turn it off explicitly to avoid the false alarm. > + _scratch_mount -o "index=on,nfs_export=off" > make_whiteout_files > check_whiteout_files ${1} ${2} > _scratch_unmount > -- > 2.20.1 >
On Tue, Oct 20, 2020 at 10:52:59AM +0800, Murphy Zhou wrote: > Ping on this one. Queued for next update. Sorry, I thought I've applied it and pushed, but clearly I didn't. Thanks for the reminder! Thanks, Eryu > > On Fri, Sep 11, 2020 at 10:18:13AM +0800, Murphy Zhou wrote: > > When nfs_export is enabled, the link count of upper dir > > objects are more then the expected number in this testcase. > > Because extra index entries are linked to upper inodes. > > > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > > --- > > tests/overlay/073 | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/overlay/073 b/tests/overlay/073 > > index 37860c92..c5deccc6 100755 > > --- a/tests/overlay/073 > > +++ b/tests/overlay/073 > > @@ -99,7 +99,9 @@ run_test_case() > > { > > _scratch_mkfs > > make_lower_files ${1} > > - _scratch_mount -o "index=on" > > + # There will be extra hard links with nfs_export enabled which > > + # is expected. Turn it off explicitly to avoid the false alarm. > > + _scratch_mount -o "index=on,nfs_export=off" > > make_whiteout_files > > check_whiteout_files ${1} ${2} > > _scratch_unmount > > -- > > 2.20.1 > > > > -- > Murphy
On Tue, Oct 20, 2020 at 01:22:29PM +0800, Eryu Guan wrote: > On Tue, Oct 20, 2020 at 10:52:59AM +0800, Murphy Zhou wrote: > > Ping on this one. > > Queued for next update. > > Sorry, I thought I've applied it and pushed, but clearly I didn't. > Thanks for the reminder! No warries :) > > Thanks, > Eryu > > > > > On Fri, Sep 11, 2020 at 10:18:13AM +0800, Murphy Zhou wrote: > > > When nfs_export is enabled, the link count of upper dir > > > objects are more then the expected number in this testcase. > > > Because extra index entries are linked to upper inodes. > > > > > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > > > --- > > > tests/overlay/073 | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/tests/overlay/073 b/tests/overlay/073 > > > index 37860c92..c5deccc6 100755 > > > --- a/tests/overlay/073 > > > +++ b/tests/overlay/073 > > > @@ -99,7 +99,9 @@ run_test_case() > > > { > > > _scratch_mkfs > > > make_lower_files ${1} > > > - _scratch_mount -o "index=on" > > > + # There will be extra hard links with nfs_export enabled which > > > + # is expected. Turn it off explicitly to avoid the false alarm. > > > + _scratch_mount -o "index=on,nfs_export=off" > > > make_whiteout_files > > > check_whiteout_files ${1} ${2} > > > _scratch_unmount > > > -- > > > 2.20.1 > > > > > > > -- > > Murphy
diff --git a/tests/overlay/073 b/tests/overlay/073 index 37860c92..c5deccc6 100755 --- a/tests/overlay/073 +++ b/tests/overlay/073 @@ -99,7 +99,9 @@ run_test_case() { _scratch_mkfs make_lower_files ${1} - _scratch_mount -o "index=on" + # There will be extra hard links with nfs_export enabled which + # is expected. Turn it off explicitly to avoid the false alarm. + _scratch_mount -o "index=on,nfs_export=off" make_whiteout_files check_whiteout_files ${1} ${2} _scratch_unmount
When nfs_export is enabled, the link count of upper dir objects are more then the expected number in this testcase. Because extra index entries are linked to upper inodes. Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> --- tests/overlay/073 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)