From patchwork Fri May 28 03:13:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Long X-Patchwork-Id: 12286123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A498C4707F for ; Fri, 28 May 2021 03:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00217613D4 for ; Fri, 28 May 2021 03:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236285AbhE1DOH (ORCPT ); Thu, 27 May 2021 23:14:07 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:2328 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236023AbhE1DOG (ORCPT ); Thu, 27 May 2021 23:14:06 -0400 Received: from dggeml703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FrqPQ6g2Mz1BFfG; Fri, 28 May 2021 11:07:54 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggeml703-chm.china.huawei.com (10.3.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 11:12:30 +0800 Received: from huawei.com (10.67.174.154) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 28 May 2021 11:12:30 +0800 From: chenlong To: , , CC: Subject: [PATCH v4] ext4/048: Add new regression test Date: Fri, 28 May 2021 11:13:07 +0800 Message-ID: <20210528031307.31244-1-chenlongcl.chen@huawei.com> X-Mailer: git-send-email 2.18.0.huawei.25 MIME-Version: 1.0 X-Originating-IP: [10.67.174.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Check the block group zero and prevent initializing reserved inodes. But in some special cases, the reserved inode may not all belong to the group zero, it may exist into the second group if we format  filesystem below. mkfs.ext4 -b 4096 -g 8192 -N 1024 -I 4096 /dev/sda So, it will end up triggering a false positive report of a corrupted file system It's a regression test for commit a149d2a5cabb. Signed-off-by: Chen Long --- tests/ext4/048 | 68 ++++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/048.out | 7 +++++ tests/ext4/group | 1 + 3 files changed, 76 insertions(+) create mode 100755 tests/ext4/048 create mode 100644 tests/ext4/048.out diff --git a/tests/ext4/048 b/tests/ext4/048 new file mode 100755 index 00000000..54f9f0e2 --- /dev/null +++ b/tests/ext4/048 @@ -0,0 +1,68 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 Huawei. All Rights Reserved. +# +# FS QA Test 048 +# +# Regression test for commit: +# a149d2a5cabb(ext4: fix check to prevent false positive report of incorrect +# used inodes) +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs ext4 +_require_scratch + +sdev=$(_short_dev ${SCRATCH_DEV}) +# default sleep interval +sleep_time=5 + +echo "+ create scratch fs" +_scratch_mkfs_ext4 -b 4096 -g 8192 -N 1024 -I 4096 >> $seqres.full 2>&1 + +echo "+ mount fs" +_scratch_mount -o errors=remount-ro +# The default maximum wake-up delay of the lazy init thread of ext4 is +# EXT4_DEF_LI_MAX_START_DELAY (5s). +# After mounting the file system, the lazy init thread will be awakened to +# perform group initialization at 0~5s after the current time. If an error +# is detected during the initialization process, it will be set to read-only, +# so the test case needs to delay a little while waiting for the init thread +# to execute. +sleep $sleep_time + +echo "+ check mountpoint status" +cat /proc/self/mounts | grep -w ${SCRATCH_MNT} | \ + $AWK_PROG '{print $4}' | grep -oE '^rw,' | tee -a $seqres.full + +echo "+ check mountpoint writability" +test -w $SCRATCH_MNT || echo "scratch mount should still be writable" + +echo "+ check dmesg" +_check_dmesg_for "\(${sdev}\): Remounting filesystem read-only" && \ + echo "scratch dev should not be remounted to read-only" + +# success, all done +status=0 +exit diff --git a/tests/ext4/048.out b/tests/ext4/048.out new file mode 100644 index 00000000..6f0075e1 --- /dev/null +++ b/tests/ext4/048.out @@ -0,0 +1,7 @@ +QA output created by 048 ++ create scratch fs ++ mount fs ++ check mountpoint status +rw, ++ check mountpoint writability ++ check dmesg diff --git a/tests/ext4/group b/tests/ext4/group index ceda2ba6..82b77efb 100644 --- a/tests/ext4/group +++ b/tests/ext4/group @@ -50,6 +50,7 @@ 045 auto dir 046 auto prealloc quick 047 auto quick dax +048 auto quick 271 auto rw quick 301 aio auto ioctl rw stress defrag 302 aio auto ioctl rw stress defrag