| Message ID | 20210908083715.1831067-2-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: Fix order of _require_scratch* and _require_dm_target | expand |
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff --git a/tests/generic/628 b/tests/generic/628 index 2ccbbbdc..7dc6dfcd 100755 --- a/tests/generic/628 +++ b/tests/generic/628 @@ -29,8 +29,8 @@ _cleanup() # real QA test starts here _supported_fs generic -_require_dm_target error _require_scratch_reflink +_require_dm_target error _require_xfs_io_command "chattr" "s" _require_cp_reflink diff --git a/tests/generic/629 b/tests/generic/629 index abfa90ab..f501555e 100755 --- a/tests/generic/629 +++ b/tests/generic/629 @@ -28,10 +28,10 @@ _cleanup() # real QA test starts here _supported_fs generic +_require_scratch _require_dm_target error _require_xfs_io_command "chattr" "s" _require_xfs_io_command "copy_range" -_require_scratch # Format filesystem and set up quota limits _scratch_mkfs > $seqres.full
Test cases with dm_target shall call _require_scratch* before _require_dm_target to ensure that valid SCRATCH_DEV is available for dm_target. However, the test cases generic/628 and generic/629 call _require_dm_target before _require_scratch*, then unexpected failure was reported when SCRATCH_DEV is not specified. Fix the order of function calls. Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- tests/generic/628 | 2 +- tests/generic/629 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)