| Message ID | 20211109175555.16795-1-lhenriques@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common/renameat2: use mktemp(1) to create temporary directory | expand |
diff --git a/common/renameat2 b/common/renameat2 index 4d25d7cebf94..9737dff54a2b 100644 --- a/common/renameat2 +++ b/common/renameat2 @@ -105,14 +105,13 @@ _rename_tests() _require_renameat2() { local flags=$1 - local rename_dir=$TEST_DIR/$$ + local rename_dir=`mktemp -d -p $TEST_DIR` local cmd="" if test ! -x $here/src/renameat2; then _notrun "renameat2 binary not found" fi - mkdir $rename_dir touch $rename_dir/foo case $flags in "noreplace")
Instead of using $TEST_DIR/$$, use the _correct_ way to create temporary directories. I've seen generic/626 failing with: QA output created by 626 mkdir: cannot create directory '/media/test/471': File exists Silence is golden which was likely due to another test that used the same directory name and didn't do the clean-up. Signed-off-by: Luís Henriques <lhenriques@suse.de> --- common/renameat2 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)