| Message ID | 20220330114540.1539-1-ddiss@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: drop no-op count=$(( count-- )) | expand |
Thanks for the fix. Reviewed-by: Anand Jain <anand.jain@oracle.com> On 30/03/2022 19:45, David Disseldorp wrote: > This line doesn't result in a changed count value. The tests don't > appear to rely on a decremented value, so remove the line. > > Signed-off-by: David Disseldorp <ddiss@suse.de> > --- > tests/btrfs/124 | 1 - > tests/btrfs/125 | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/tests/btrfs/124 b/tests/btrfs/124 > index e8d77aaa..3d8141a1 100755 > --- a/tests/btrfs/124 > +++ b/tests/btrfs/124 > @@ -74,7 +74,6 @@ _scratch_mount >> $seqres.full 2>&1 > _run_btrfs_util_prog filesystem show > dd if=/dev/zero of="$SCRATCH_MNT"/tf1 bs=$bs count=1 \ > >>$seqres.full 2>&1 > -count=$(( count-- )) > echo "unmount" >> $seqres.full > echo "clean btrfs ko" >> $seqres.full > _scratch_unmount > diff --git a/tests/btrfs/125 b/tests/btrfs/125 > index 44ba49ec..b58f2aa2 100755 > --- a/tests/btrfs/125 > +++ b/tests/btrfs/125 > @@ -80,7 +80,6 @@ dd if=/dev/zero of="$SCRATCH_MNT"/tf1 bs=$bs count=1 \ > >>$seqres.full 2>&1 > _run_btrfs_util_prog filesystem show > _run_btrfs_util_prog filesystem df $SCRATCH_MNT > -count=$(( count-- )) > > #-------------degraded-init------------------- > echo >> $seqres.full
diff --git a/tests/btrfs/124 b/tests/btrfs/124 index e8d77aaa..3d8141a1 100755 --- a/tests/btrfs/124 +++ b/tests/btrfs/124 @@ -74,7 +74,6 @@ _scratch_mount >> $seqres.full 2>&1 _run_btrfs_util_prog filesystem show dd if=/dev/zero of="$SCRATCH_MNT"/tf1 bs=$bs count=1 \ >>$seqres.full 2>&1 -count=$(( count-- )) echo "unmount" >> $seqres.full echo "clean btrfs ko" >> $seqres.full _scratch_unmount diff --git a/tests/btrfs/125 b/tests/btrfs/125 index 44ba49ec..b58f2aa2 100755 --- a/tests/btrfs/125 +++ b/tests/btrfs/125 @@ -80,7 +80,6 @@ dd if=/dev/zero of="$SCRATCH_MNT"/tf1 bs=$bs count=1 \ >>$seqres.full 2>&1 _run_btrfs_util_prog filesystem show _run_btrfs_util_prog filesystem df $SCRATCH_MNT -count=$(( count-- )) #-------------degraded-init------------------- echo >> $seqres.full
This line doesn't result in a changed count value. The tests don't appear to rely on a decremented value, so remove the line. Signed-off-by: David Disseldorp <ddiss@suse.de> --- tests/btrfs/124 | 1 - tests/btrfs/125 | 1 - 2 files changed, 2 deletions(-)