| Message ID | 20220516060807.1295102-4-david@fromorbit.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: test updates for XFS 5.19 kernel mods | expand |
On Mon, May 16, 2022 at 04:08:07PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@redhat.com> > > The output of xfs/348 encodes the observed behaviour at the time the > test was written, not the correct behaviour that should occur. > Recent improvements in verification checking in the upstream kernel > (1eb70f54c445 "xfs: validate inode fork size against fork format") > have resulted in the kernel having correct behaviour and now the > test fails. Fix the test output to reflect correct behaviour. > > Signed-off-by: Dave Chinner <dchinner@redhat.com> Heh, I've long wondered (but never had the time) to go figure out why more things weren't failing. Thx for fixing the kernel. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > tests/xfs/348.out | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/xfs/348.out b/tests/xfs/348.out > index 0d407718..9130f42a 100644 > --- a/tests/xfs/348.out > +++ b/tests/xfs/348.out > @@ -108,7 +108,7 @@ would have junked entry "DATA" in directory PARENT_INO > would have junked entry "EMPTY" in directory PARENT_INO > would have junked entry "FIFO" in directory PARENT_INO > stat: 'SCRATCH_MNT/test/DIR' is a directory > -stat: 'SCRATCH_MNT/test/DATA' is a directory > +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning > stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning > stat: cannot statx 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning > stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning > @@ -240,7 +240,7 @@ would have junked entry "DIR" in directory PARENT_INO > would have junked entry "EMPTY" in directory PARENT_INO > would have junked entry "FIFO" in directory PARENT_INO > stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning > -stat: 'SCRATCH_MNT/test/DATA' is a symbolic link > +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning > stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning > stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link > stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning > -- > 2.35.1 >
diff --git a/tests/xfs/348.out b/tests/xfs/348.out index 0d407718..9130f42a 100644 --- a/tests/xfs/348.out +++ b/tests/xfs/348.out @@ -108,7 +108,7 @@ would have junked entry "DATA" in directory PARENT_INO would have junked entry "EMPTY" in directory PARENT_INO would have junked entry "FIFO" in directory PARENT_INO stat: 'SCRATCH_MNT/test/DIR' is a directory -stat: 'SCRATCH_MNT/test/DATA' is a directory +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning @@ -240,7 +240,7 @@ would have junked entry "DIR" in directory PARENT_INO would have junked entry "EMPTY" in directory PARENT_INO would have junked entry "FIFO" in directory PARENT_INO stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning -stat: 'SCRATCH_MNT/test/DATA' is a symbolic link +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning