From patchwork Mon May 16 06:08:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Chinner X-Patchwork-Id: 12850281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1865BC4332F for ; Mon, 16 May 2022 06:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238317AbiEPGI1 (ORCPT ); Mon, 16 May 2022 02:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240209AbiEPGIO (ORCPT ); Mon, 16 May 2022 02:08:14 -0400 Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5701E21243 for ; Sun, 15 May 2022 23:08:11 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 337D710E695D for ; Mon, 16 May 2022 16:08:11 +1000 (AEST) Received: from discord.disaster.area ([192.168.253.110]) by dread.disaster.area with esmtp (Exim 4.92.3) (envelope-from ) id 1nqTtp-00CYbH-Gv for fstests@vger.kernel.org; Mon, 16 May 2022 16:08:09 +1000 Received: from dave by discord.disaster.area with local (Exim 4.95) (envelope-from ) id 1nqTtp-005QwN-Fy for fstests@vger.kernel.org; Mon, 16 May 2022 16:08:09 +1000 From: Dave Chinner To: fstests@vger.kernel.org Subject: [PATCH 3/3] xfs/348: golden output is not correct Date: Mon, 16 May 2022 16:08:07 +1000 Message-Id: <20220516060807.1295102-4-david@fromorbit.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220516060807.1295102-1-david@fromorbit.com> References: <20220516060807.1295102-1-david@fromorbit.com> MIME-Version: 1.0 X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=e9dl9Yl/ c=1 sm=1 tr=0 ts=6281ea4b a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=oZkIemNP1mAA:10 a=20KFwNOVAAAA:8 a=bLOITkrf0B9LOGp-q54A:9 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Dave Chinner The output of xfs/348 encodes the observed behaviour at the time the test was written, not the correct behaviour that should occur. Recent improvements in verification checking in the upstream kernel (1eb70f54c445 "xfs: validate inode fork size against fork format") have resulted in the kernel having correct behaviour and now the test fails. Fix the test output to reflect correct behaviour. Signed-off-by: Dave Chinner Reviewed-by: Darrick J. Wong --- tests/xfs/348.out | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xfs/348.out b/tests/xfs/348.out index 0d407718..9130f42a 100644 --- a/tests/xfs/348.out +++ b/tests/xfs/348.out @@ -108,7 +108,7 @@ would have junked entry "DATA" in directory PARENT_INO would have junked entry "EMPTY" in directory PARENT_INO would have junked entry "FIFO" in directory PARENT_INO stat: 'SCRATCH_MNT/test/DIR' is a directory -stat: 'SCRATCH_MNT/test/DATA' is a directory +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning @@ -240,7 +240,7 @@ would have junked entry "DIR" in directory PARENT_INO would have junked entry "EMPTY" in directory PARENT_INO would have junked entry "FIFO" in directory PARENT_INO stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning -stat: 'SCRATCH_MNT/test/DATA' is a symbolic link +stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning