diff mbox series

[1/6] check: avoid FSTYP=<fstyp parameter> repetition

Message ID 20220620192934.21694-2-ddiss@suse.de (mailing list archive)
State New, archived
Headers show
Series check: minor cleanups and xunit report fix | expand

Commit Message

David Disseldorp June 20, 2022, 7:29 p.m. UTC 
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 check | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

Comments

Zorro Lang June 22, 2022, 4:27 a.m. UTC | #1 
On Mon, Jun 20, 2022 at 09:29:29PM +0200, David Disseldorp wrote:
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
>  check | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/check b/check
> index de11b37e..42925e09 100755
> --- a/check
> +++ b/check
> @@ -277,15 +277,13 @@ while [ $# -gt 0 ]; do
>  	case "$1" in
>  	-\? | -h | --help) usage ;;
>  
> -	-nfs)		FSTYP=nfs ;;
> -	-glusterfs)	FSTYP=glusterfs ;;
> -	-cifs)		FSTYP=cifs ;;
> -	-9p)		FSTYP=9p ;;
> -	-virtiofs)	FSTYP=virtiofs ;;
> -	-overlay)	FSTYP=overlay; export OVERLAY=true ;;
> -	-pvfs2)		FSTYP=pvfs2 ;;
> -	-tmpfs)		FSTYP=tmpfs ;;
> -	-ubifs)		FSTYP=ubifs ;;
> +	-nfs|-glusterfs|-cifs|-9p|-virtiofs|-pvfs2|-tmpfs|-ubifs)
> +		FSTYP="${1:1}"
> +		;;
> +	-overlay)
> +		FSTYP=overlay
> +		export OVERLAY=true
> +		;;

Looks good.

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  
>  	-g)	group=$2 ; shift ;
>  		GROUP_LIST="$GROUP_LIST ${group//,/ }"
> -- 
> 2.35.3
>
diff mbox series

Patch

diff --git a/check b/check
index de11b37e..42925e09 100755
--- a/check
+++ b/check
@@ -277,15 +277,13 @@  while [ $# -gt 0 ]; do
 	case "$1" in
 	-\? | -h | --help) usage ;;
 
-	-nfs)		FSTYP=nfs ;;
-	-glusterfs)	FSTYP=glusterfs ;;
-	-cifs)		FSTYP=cifs ;;
-	-9p)		FSTYP=9p ;;
-	-virtiofs)	FSTYP=virtiofs ;;
-	-overlay)	FSTYP=overlay; export OVERLAY=true ;;
-	-pvfs2)		FSTYP=pvfs2 ;;
-	-tmpfs)		FSTYP=tmpfs ;;
-	-ubifs)		FSTYP=ubifs ;;
+	-nfs|-glusterfs|-cifs|-9p|-virtiofs|-pvfs2|-tmpfs|-ubifs)
+		FSTYP="${1:1}"
+		;;
+	-overlay)
+		FSTYP=overlay
+		export OVERLAY=true
+		;;
 
 	-g)	group=$2 ; shift ;
 		GROUP_LIST="$GROUP_LIST ${group//,/ }"