| Message ID | 20220818113905.402441-1-preichl@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] generic: test i_blocks for large files | expand |
On Thu, Aug 18, 2022 at 01:39:05PM +0200, Pavel Reichl wrote: > This is a regression test for an incorrect > computation of i_blocks for files larger than > 4 GiB. Bug was filed for exFAT. > > Signed-off-by: Pavel Reichl <preichl@redhat.com> > --- This version looks good to me, just a tiny problem, generic/693 has been taken by current upstream xfstests for-next branch, would you mind rebasing this patch to latest xfstests? Anyway you can have: Reviewed-by: Zorro Lang <zlang@redhat.com> > tests/generic/693 | 47 +++++++++++++++++++++++++++++++++++++++++++ > tests/generic/693.out | 2 ++ > 2 files changed, 49 insertions(+) > create mode 100755 tests/generic/693 > create mode 100644 tests/generic/693.out > > diff --git a/tests/generic/693 b/tests/generic/693 > new file mode 100755 > index 00000000..29992ed0 > --- /dev/null > +++ b/tests/generic/693 > @@ -0,0 +1,47 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2022 Red Hat Inc. All Rights Reserved. > +# > +# FS QA Test 693 > +# > +# Verify that i_blocks for files larger than 4 GiB have correct > +# values. > +# > +# This test verifies the problem fixed in kernel with commit > +# 0c336d6e33f4 exfat: fix incorrect loading of i_blocks for large files > +# > +. ./common/preamble > +_begin_fstest auto > + > +# Override the default cleanup function. > +_cleanup() > +{ > + cd / > + rm -r -f $tmp.* $junk_dir > +} > + > +_supported_fs generic > +_require_test > +_require_fs_space $TEST_DIR $((4 * 1024 * 1024)) #kB > + > +echo "Silence is golden" > + > +junk_dir=$TEST_DIR/$seq > +junk_file=$junk_dir/junk > +mkdir -p $junk_dir > + > +$XFS_IO_PROG -f -c "pwrite -W 0 4G" $junk_file > /dev/null > + > +iblocks=`stat -c '%b' $junk_file` > + > +_test_cycle_mount > + > +iblocks_after_remount=`stat -c '%b' $junk_file` > + > +if [ "$iblocks" != "$iblocks_after_remount" ]; then > + echo "Number of blocks needs to be same: $iblocks, $iblocks_after_remount" > +fi > + > +status=0 > + > +exit > diff --git a/tests/generic/693.out b/tests/generic/693.out > new file mode 100644 > index 00000000..01884ea5 > --- /dev/null > +++ b/tests/generic/693.out > @@ -0,0 +1,2 @@ > +QA output created by 693 > +Silence is golden > -- > 2.37.2 >
diff --git a/tests/generic/693 b/tests/generic/693 new file mode 100755 index 00000000..29992ed0 --- /dev/null +++ b/tests/generic/693 @@ -0,0 +1,47 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2022 Red Hat Inc. All Rights Reserved. +# +# FS QA Test 693 +# +# Verify that i_blocks for files larger than 4 GiB have correct +# values. +# +# This test verifies the problem fixed in kernel with commit +# 0c336d6e33f4 exfat: fix incorrect loading of i_blocks for large files +# +. ./common/preamble +_begin_fstest auto + +# Override the default cleanup function. +_cleanup() +{ + cd / + rm -r -f $tmp.* $junk_dir +} + +_supported_fs generic +_require_test +_require_fs_space $TEST_DIR $((4 * 1024 * 1024)) #kB + +echo "Silence is golden" + +junk_dir=$TEST_DIR/$seq +junk_file=$junk_dir/junk +mkdir -p $junk_dir + +$XFS_IO_PROG -f -c "pwrite -W 0 4G" $junk_file > /dev/null + +iblocks=`stat -c '%b' $junk_file` + +_test_cycle_mount + +iblocks_after_remount=`stat -c '%b' $junk_file` + +if [ "$iblocks" != "$iblocks_after_remount" ]; then + echo "Number of blocks needs to be same: $iblocks, $iblocks_after_remount" +fi + +status=0 + +exit diff --git a/tests/generic/693.out b/tests/generic/693.out new file mode 100644 index 00000000..01884ea5 --- /dev/null +++ b/tests/generic/693.out @@ -0,0 +1,2 @@ +QA output created by 693 +Silence is golden
This is a regression test for an incorrect computation of i_blocks for files larger than 4 GiB. Bug was filed for exFAT. Signed-off-by: Pavel Reichl <preichl@redhat.com> --- tests/generic/693 | 47 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/693.out | 2 ++ 2 files changed, 49 insertions(+) create mode 100755 tests/generic/693 create mode 100644 tests/generic/693.out