diff mbox series

[2/5] ext4: Zero bytes after 'oldsize' if we're expanding the file

Message ID 20230202204428.3267832-3-willy@infradead.org (mailing list archive)
State New, archived
Headers show
Series Fix a minor POSIX conformance problem | expand

Commit Message

Matthew Wilcox Feb. 2, 2023, 8:44 p.m. UTC
POSIX requires that "If the file size is increased, the extended area
shall appear as if it were zero-filled".  It is possible to use mmap to
write past EOF and that data will become visible instead of zeroes.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
 fs/ext4/inode.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9d9f414f99fe..14e3fa99f733 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5604,6 +5604,7 @@  int ext4_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
 			if (!shrink) {
 				pagecache_isize_extended(inode, oldsize,
+				truncate_pagecache(inode, oldsize);
 			} else if (ext4_should_journal_data(inode)) {