| Message ID | 20230424141042.450535-7-dhowells@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfstests: Add support for using xfstests to test AFS | expand |
On Mon, Apr 24, 2023 at 03:10:42PM +0100, David Howells wrote: > AFS doesn't support the "noacl" command line option. ACLs are mandatory > and interpreted by the server. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: linux-afs@lists.infradead.org > --- > tests/generic/696 | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/generic/696 b/tests/generic/696 > index 178d78e1..55a2fd5a 100755 > --- a/tests/generic/696 > +++ b/tests/generic/696 > @@ -31,7 +31,10 @@ _scratch_mkfs >$seqres.full 2>&1 > $here/src/vfs/vfstest --test-setgid-create-umask \ > --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP" > > -export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS" > +if [ "$FSTYP" != afs ] > +then > + export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS" > +fi Good to me, Reviewed-by: Zorro Lang <zlang@redhat.com> > > # Also test S_ISGID stripping whether works correctly on underflying filesystem > # that supports noacl feature. >
diff --git a/tests/generic/696 b/tests/generic/696 index 178d78e1..55a2fd5a 100755 --- a/tests/generic/696 +++ b/tests/generic/696 @@ -31,7 +31,10 @@ _scratch_mkfs >$seqres.full 2>&1 $here/src/vfs/vfstest --test-setgid-create-umask \ --device "$TEST_DEV" --mount "$TEST_DIR" --fstype "$FSTYP" -export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS" +if [ "$FSTYP" != afs ] +then + export MOUNT_OPTIONS="-o noacl $MOUNT_OPTIONS" +fi # Also test S_ISGID stripping whether works correctly on underflying filesystem # that supports noacl feature.
AFS doesn't support the "noacl" command line option. ACLs are mandatory and interpreted by the server. Signed-off-by: David Howells <dhowells@redhat.com> cc: linux-afs@lists.infradead.org --- tests/generic/696 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)