| Message ID | 20230707192704.2654426-2-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-v2,1/2] report: safely update the result.xml file | expand |
diff --git a/common/report b/common/report index 3c58f0e3c..0e91e481f 100644 --- a/common/report +++ b/common/report @@ -128,7 +128,6 @@ _xunit_make_section_report() local fstests_ns="https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git" cat >> "$tmp_fn" << ENDL <testsuite - xmlns="$fstests_ns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="$fstests_ns $fstests_ns/tree/doc/xunit.xsd"
By specifying "xmlns=https://git.kernel.org/.../xfstests-dev.git", this causes XML complaint parsers, such as the one used by the python junitparser library, to put all of the XML elements into a namespace, which then causes junitparser to toss its cookies. This can be worked-around in a test runner script via: sed -i.orig -e 's/xmlns=\".*\"//' "$RESULT_BASE/result.xml" but it's better not to include the xmlns line at all in the first place, since this may cause other users of fstests who are using the Python junitparser library a lot of headaches. Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Darrick J. Wong <djwong@kernel.org> --- changes from v1: * minor updates to the commit description common/report | 1 - 1 file changed, 1 deletion(-)