| Message ID | 20230727190512.357064-1-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: install soak_duration.awk | expand |
On Thu, Jul 27, 2023 at 03:05:12PM -0400, Theodore Ts'o wrote: > Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a > helper executable, soak_duration.awk, is which used by the check > script if SOAK_DURATION is set. This script translates a > "human-firendly" time duration specifier, such as 4m or 2d into an > integer number of seconds. We need to make sure that this script is > installed or the checks script will bomb out of SOAK_DURATION is set > (and the fstests installation doesn't include a full set of fstests > source, but just those files installed by "make install"). > > Fixes: 3e85dd4fe423 ("misc: add duration for long soak tests") > Cc: Darrick J. Wong <djwong@kernel.org> > Signed-off-by: Theodore Ts'o <tytso@mit.edu> Oooooops, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > src/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/Makefile b/src/Makefile > index 24cd47479..aff871d04 100644 > --- a/src/Makefile > +++ b/src/Makefile > @@ -36,7 +36,8 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ > uuid_ioctl > > EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \ > - btrfs_crc32c_forged_name.py popdir.pl popattr.py > + btrfs_crc32c_forged_name.py popdir.pl popattr.py \ > + soak_duration.awk > > SUBDIRS = log-writes perf > > -- > 2.31.0 >
On Thu, Jul 27, 2023 at 03:05:12PM -0400, Theodore Ts'o wrote: > Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a > helper executable, soak_duration.awk, is which used by the check > script if SOAK_DURATION is set. This script translates a > "human-firendly" time duration specifier, such as 4m or 2d into an s/firendly/friendly/ > integer number of seconds. We need to make sure that this script is > installed or the checks script will bomb out of SOAK_DURATION is set s/checks/check/ > (and the fstests installation doesn't include a full set of fstests > source, but just those files installed by "make install"). s/and/and if/ Apologies for the typos in the commit description. - Ted
On Thu, Jul 27, 2023 at 04:39:43PM -0400, Theodore Ts'o wrote: > On Thu, Jul 27, 2023 at 03:05:12PM -0400, Theodore Ts'o wrote: > > Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a > > helper executable, soak_duration.awk, is which used by the check > > script if SOAK_DURATION is set. This script translates a > > "human-firendly" time duration specifier, such as 4m or 2d into an > > s/firendly/friendly/ > > > integer number of seconds. We need to make sure that this script is > > installed or the checks script will bomb out of SOAK_DURATION is set > > s/checks/check/ > > > (and the fstests installation doesn't include a full set of fstests > > source, but just those files installed by "make install"). > > s/and/and if/ > > Apologies for the typos in the commit description. Thanks for this fix, I'll fix that when I merge it. Thanks, Zorro > > - Ted >
On Thu, Jul 27, 2023 at 12:18:24PM -0700, Darrick J. Wong wrote:
> > installed or the checks script will bomb out of SOAK_DURATION is set
One more typo fix: s/of/if/
I think I've gotten way too spoiled by automatic spell/grammar
checking in GMail and Google Docs....
- Ted
diff --git a/src/Makefile b/src/Makefile index 24cd47479..aff871d04 100644 --- a/src/Makefile +++ b/src/Makefile @@ -36,7 +36,8 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ uuid_ioctl EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \ - btrfs_crc32c_forged_name.py popdir.pl popattr.py + btrfs_crc32c_forged_name.py popdir.pl popattr.py \ + soak_duration.awk SUBDIRS = log-writes perf
Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a helper executable, soak_duration.awk, is which used by the check script if SOAK_DURATION is set. This script translates a "human-firendly" time duration specifier, such as 4m or 2d into an integer number of seconds. We need to make sure that this script is installed or the checks script will bomb out of SOAK_DURATION is set (and the fstests installation doesn't include a full set of fstests source, but just those files installed by "make install"). Fixes: 3e85dd4fe423 ("misc: add duration for long soak tests") Cc: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- src/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)