diff mbox series

fsstress: unify verbose output format

Message ID 20231123085843.1152470-1-ruansy.fnst@fujitsu.com (mailing list archive)
State New, archived
Headers show
Series fsstress: unify verbose output format | expand

Commit Message

Shiyang Ruan Nov. 23, 2023, 8:58 a.m. UTC
Wrap offset, length within '[]' and remove meanless 't' in
do_fallocate().

Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
---
 ltp/fsstress.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Zorro Lang Dec. 4, 2023, 2:20 p.m. UTC | #1
On Thu, Nov 23, 2023 at 04:58:43PM +0800, Shiyang Ruan wrote:
> Wrap offset, length within '[]' and remove meanless 't' in
> do_fallocate().
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> ---

The fix for the meanless 't' is good to me. And I don't have objections
for other output format changes.

Reviewed-by: Zorro Lang <zlang@redhat.com>

Thanks,
Zorro

>  ltp/fsstress.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index abe287425..9778fce82 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -3810,7 +3810,7 @@ do_fallocate(opnum_t opno, long r, int mode)
>  	mode |= FALLOC_FL_KEEP_SIZE & random();
>  	e = fallocate(fd, mode, (loff_t)off, (loff_t)len) < 0 ? errno : 0;
>  	if (v)
> -		printf("%d/%lld: fallocate(%s) %s %st %lld %lld %d\n",
> +		printf("%d/%lld: fallocate(%s) %s%s [%lld,%lld] %d\n",
>  		       procid, opno, translate_falloc_flags(mode),
>  		       f.path, st, (long long)off, (long long)len, e);
>  	free_pathname(&f);
> @@ -3932,7 +3932,7 @@ fiemap_f(opnum_t opno, long r)
>  
>  	e = ioctl(fd, FS_IOC_FIEMAP, (unsigned long)fiemap);
>  	if (v)
> -		printf("%d/%lld: ioctl(FIEMAP) %s%s %lld %lld (%s) %d\n",
> +		printf("%d/%lld: ioctl(FIEMAP) %s%s [%lld,%lld,%s] %d\n",
>  		       procid, opno, f.path, st, (long long)fiemap->fm_start,
>  		       (long long) fiemap->fm_length,
>  		       translate_fiemap_flags(fiemap->fm_flags), e);
> @@ -4866,7 +4866,7 @@ resvsp_f(opnum_t opno, long r)
>  	fl.l_len = (off64_t)(random() % (1024 * 1024));
>  	e = xfsctl(f.path, fd, XFS_IOC_RESVSP64, &fl) < 0 ? errno : 0;
>  	if (v)
> -		printf("%d/%lld: xfsctl(XFS_IOC_RESVSP64) %s%s %lld %lld %d\n",
> +		printf("%d/%lld: xfsctl(XFS_IOC_RESVSP64) %s%s [%lld,%lld] %d\n",
>  		       procid, opno, f.path, st,
>  			(long long)off, (long long)fl.l_len, e);
>  	free_pathname(&f);
> @@ -5334,7 +5334,7 @@ unresvsp_f(opnum_t opno, long r)
>  	fl.l_len = (off64_t)(random() % (1 << 20));
>  	e = xfsctl(f.path, fd, XFS_IOC_UNRESVSP64, &fl) < 0 ? errno : 0;
>  	if (v)
> -		printf("%d/%lld: xfsctl(XFS_IOC_UNRESVSP64) %s%s %lld %lld %d\n",
> +		printf("%d/%lld: xfsctl(XFS_IOC_UNRESVSP64) %s%s [%lld,%lld] %d\n",
>  		       procid, opno, f.path, st,
>  			(long long)off, (long long)fl.l_len, e);
>  	free_pathname(&f);
> -- 
> 2.42.1
> 
>
diff mbox series

Patch

diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index abe287425..9778fce82 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -3810,7 +3810,7 @@  do_fallocate(opnum_t opno, long r, int mode)
 	mode |= FALLOC_FL_KEEP_SIZE & random();
 	e = fallocate(fd, mode, (loff_t)off, (loff_t)len) < 0 ? errno : 0;
 	if (v)
-		printf("%d/%lld: fallocate(%s) %s %st %lld %lld %d\n",
+		printf("%d/%lld: fallocate(%s) %s%s [%lld,%lld] %d\n",
 		       procid, opno, translate_falloc_flags(mode),
 		       f.path, st, (long long)off, (long long)len, e);
 	free_pathname(&f);
@@ -3932,7 +3932,7 @@  fiemap_f(opnum_t opno, long r)
 
 	e = ioctl(fd, FS_IOC_FIEMAP, (unsigned long)fiemap);
 	if (v)
-		printf("%d/%lld: ioctl(FIEMAP) %s%s %lld %lld (%s) %d\n",
+		printf("%d/%lld: ioctl(FIEMAP) %s%s [%lld,%lld,%s] %d\n",
 		       procid, opno, f.path, st, (long long)fiemap->fm_start,
 		       (long long) fiemap->fm_length,
 		       translate_fiemap_flags(fiemap->fm_flags), e);
@@ -4866,7 +4866,7 @@  resvsp_f(opnum_t opno, long r)
 	fl.l_len = (off64_t)(random() % (1024 * 1024));
 	e = xfsctl(f.path, fd, XFS_IOC_RESVSP64, &fl) < 0 ? errno : 0;
 	if (v)
-		printf("%d/%lld: xfsctl(XFS_IOC_RESVSP64) %s%s %lld %lld %d\n",
+		printf("%d/%lld: xfsctl(XFS_IOC_RESVSP64) %s%s [%lld,%lld] %d\n",
 		       procid, opno, f.path, st,
 			(long long)off, (long long)fl.l_len, e);
 	free_pathname(&f);
@@ -5334,7 +5334,7 @@  unresvsp_f(opnum_t opno, long r)
 	fl.l_len = (off64_t)(random() % (1 << 20));
 	e = xfsctl(f.path, fd, XFS_IOC_UNRESVSP64, &fl) < 0 ? errno : 0;
 	if (v)
-		printf("%d/%lld: xfsctl(XFS_IOC_UNRESVSP64) %s%s %lld %lld %d\n",
+		printf("%d/%lld: xfsctl(XFS_IOC_UNRESVSP64) %s%s [%lld,%lld] %d\n",
 		       procid, opno, f.path, st,
 			(long long)off, (long long)fl.l_len, e);
 	free_pathname(&f);