diff mbox series

generic/747: Redirect stderr of _scratch_mkfs_sized

Message ID 20240606055759.2594-1-maxj.fnst@fujitsu.com (mailing list archive)
State New, archived
Headers show
Series generic/747: Redirect stderr of _scratch_mkfs_sized | expand

Commit Message

Ma Xinjian June 6, 2024, 5:58 a.m. UTC
The mkfs tool may output some information into stderr, which will cause the
output check failed.

In _scratch_mkfs_sized, the return value of mkfs tool is checked. So the
error message can be redirect to stdout, just like what other cases do.

Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
---
 tests/generic/747 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong June 6, 2024, 2:55 p.m. UTC | #1
On Thu, Jun 06, 2024 at 01:58:00PM +0800, Ma Xinjian wrote:
> The mkfs tool may output some information into stderr, which will cause the
> output check failed.
> 
> In _scratch_mkfs_sized, the return value of mkfs tool is checked. So the
> error message can be redirect to stdout, just like what other cases do.

Read list please
https://lore.kernel.org/fstests/171744525128.1531941.8755552045266618674.stgit@frogsfrogsfrogs/

--D

> Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> ---
>  tests/generic/747 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/747 b/tests/generic/747
> index 50b7ae11..a0da1be5 100755
> --- a/tests/generic/747
> +++ b/tests/generic/747
> @@ -99,7 +99,7 @@ seed=$RANDOM
>  RANDOM=$seed
>  echo "Running test with seed=$seed" >>$seqres.full
>  
> -_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full
> +_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
>  _scratch_mount
>  
>  echo "Starting fillup using direct IO"
> -- 
> 2.39.3
> 
>
diff mbox series

Patch

diff --git a/tests/generic/747 b/tests/generic/747
index 50b7ae11..a0da1be5 100755
--- a/tests/generic/747
+++ b/tests/generic/747
@@ -99,7 +99,7 @@  seed=$RANDOM
 RANDOM=$seed
 echo "Running test with seed=$seed" >>$seqres.full
 
-_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full
+_scratch_mkfs_sized $((8 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
 _scratch_mount
 
 echo "Starting fillup using direct IO"