| Message ID | 20240614061722.1080-3-da.gomez@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tmpfs fixes | expand |
On Fri, Jun 14, 2024 at 06:17:24AM +0000, Daniel Gomez wrote: > Do not allow the overwriting of the RECREATE_TEST_DEV variable. When > this variable is enabled, common/rc -> common/config will reset it > to false after the test device recreation process. This allows for > differentiation in mount options for SCRATCH and TEST. > > Signed-off-by: Daniel Gomez <da.gomez@samsung.com> Seems sensible to me -- all the other config section variables work this way (previous value left alone unless explicitly set by the new section). Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > common/config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/config b/common/config > index a1cd14de6..43b32b93d 100644 > --- a/common/config > +++ b/common/config > @@ -94,7 +94,7 @@ export PWD=`pwd` > export MALLOCLIB=${MALLOCLIB:=/usr/lib/libefence.a} > export LOCAL_CONFIGURE_OPTIONS=${LOCAL_CONFIGURE_OPTIONS:=--enable-readline=yes} > > -export RECREATE_TEST_DEV=false > +export RECREATE_TEST_DEV=${RECREATE_TEST_DEV:=false} > > # Handle mkfs.$fstyp which does (or does not) require -f to overwrite > set_mkfs_prog_path_with_opts() > -- > 2.43.0 >
On Fri, Jun 14, 2024 at 06:17:24AM +0000, Daniel Gomez wrote: > Do not allow the overwriting of the RECREATE_TEST_DEV variable. When > this variable is enabled, common/rc -> common/config will reset it > to false after the test device recreation process. This allows for > differentiation in mount options for SCRATCH and TEST. > > Signed-off-by: Daniel Gomez <da.gomez@samsung.com> > --- > common/config | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/config b/common/config > index a1cd14de6..43b32b93d 100644 > --- a/common/config > +++ b/common/config > @@ -94,7 +94,7 @@ export PWD=`pwd` > export MALLOCLIB=${MALLOCLIB:=/usr/lib/libefence.a} > export LOCAL_CONFIGURE_OPTIONS=${LOCAL_CONFIGURE_OPTIONS:=--enable-readline=yes} > > -export RECREATE_TEST_DEV=false > +export RECREATE_TEST_DEV=${RECREATE_TEST_DEV:=false} Oh, that makes sense. Looks like the RECREATE_TEST_DEV doesn't work long time. I'm wondering why we didn't notice that in 87f90a2dae7a4a ("common/rc: Enable _test_mkfs to force a mkfs on a xfs filesystem") Anyway, Reviewed-by: Zorro Lang <zlang@redhat.com> > > # Handle mkfs.$fstyp which does (or does not) require -f to overwrite > set_mkfs_prog_path_with_opts() > -- > 2.43.0 >
diff --git a/common/config b/common/config index a1cd14de6..43b32b93d 100644 --- a/common/config +++ b/common/config @@ -94,7 +94,7 @@ export PWD=`pwd` export MALLOCLIB=${MALLOCLIB:=/usr/lib/libefence.a} export LOCAL_CONFIGURE_OPTIONS=${LOCAL_CONFIGURE_OPTIONS:=--enable-readline=yes} -export RECREATE_TEST_DEV=false +export RECREATE_TEST_DEV=${RECREATE_TEST_DEV:=false} # Handle mkfs.$fstyp which does (or does not) require -f to overwrite set_mkfs_prog_path_with_opts()
Do not allow the overwriting of the RECREATE_TEST_DEV variable. When this variable is enabled, common/rc -> common/config will reset it to false after the test device recreation process. This allows for differentiation in mount options for SCRATCH and TEST. Signed-off-by: Daniel Gomez <da.gomez@samsung.com> --- common/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)