| Message ID | 20240630-common-fixes-v2-2-16d26fb1dee0@samsung.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | common fixes | expand |
On Sun, Jun 30, 2024 at 11:52:41PM +0200, Daniel Gomez via B4 Relay wrote: > From: Daniel Gomez <da.gomez@samsung.com> > > Add support for test device recreation (RECREATE_TEST_DEV=true) for > tmpfs. > > Signed-off-by: Daniel Gomez <da.gomez@samsung.com> > --- > common/rc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/common/rc b/common/rc > index 163041fea..51827119c 100644 > --- a/common/rc > +++ b/common/rc > @@ -604,6 +604,9 @@ _test_mkfs() > pvfs2) > # do nothing for pvfs2 > ;; > + tmpfs) Indentation problem here. > + # do nothing for tmpfs If we're recreating the test filesystem, shouldn't that unmount and remount for tmpfs? Or at least rm -rf everything underneath it? That's generally the effect of _test_mkfs for disk filesystems. (That said, I'm much less familiar with non-disk filesystems...) --D > + ;; > udf) > $MKFS_UDF_PROG $MKFS_OPTIONS $* $TEST_DEV > /dev/null > ;; > > -- > 2.43.0 > > >
diff --git a/common/rc b/common/rc index 163041fea..51827119c 100644 --- a/common/rc +++ b/common/rc @@ -604,6 +604,9 @@ _test_mkfs() pvfs2) # do nothing for pvfs2 ;; + tmpfs) + # do nothing for tmpfs + ;; udf) $MKFS_UDF_PROG $MKFS_OPTIONS $* $TEST_DEV > /dev/null ;;