[35/40] xfs/076: fix broken mkfs filtering

Message ID	20241127045403.3665299-36-david@fromorbit.com (mailing list archive)
State	New
Headers	show Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6808E10E0 for <fstests@vger.kernel.org>; Wed, 27 Nov 2024 05:00:18 +0000 (UTC) From: Dave Chinner <david@fromorbit.com> To: fstests@vger.kernel.org Subject: [PATCH 35/40] xfs/076: fix broken mkfs filtering Date: Wed, 27 Nov 2024 15:52:05 +1100 Message-ID: <20241127045403.3665299-36-david@fromorbit.com> In-Reply-To: <20241127045403.3665299-1-david@fromorbit.com> References: <20241127045403.3665299-1-david@fromorbit.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	fstests: concurrent test execution \| expand [RFC,00/40] fstests: concurrent test execution [01/40] xfs/448: get rid of assert-on-failure [02/40] fstests: cleanup fsstress process management [03/40] fuzzy: don't use killall [04/40] fstests: per-test dmflakey instances [05/40] fstests: per-test dmerror instances [06/40] fstests: per-test dmhuge instances [07/40] fstests: per-test dmthin instances [08/40] fstests: per-test dmdust instances [09/40] fstests: per-test dmdelay instances [10/40] fstests: fix DM device creation/removal vs udev races [11/40] fstests: use syncfs rather than sync [12/40] fstests: clean up mount and unmount operations [13/40] fstests: clean up loop device instantiation [14/40] fstests: xfs/227 is really slow [15/40] fstests: mark tests that are unreliable when run in parallel [16/40] fstests: use udevadm wait in preference to settle [17/40] xfs/442: rescale load so it's not exponential [18/40] xfs/176: fix broken setup code [19/40] xfs/177: remove unused slab object count location checks [20/40] fstests: remove uses of killall where possible [21/40] generic/127: reduce runtime [22/40] quota: system project quota files need to be shared [23/40] dmesg: reduce noise from other tests [24/40] fstests: stop using /tmp directly [25/40] fstests: scale some tests for high CPU count sanity [26/40] generic/310: cleanup killing background processes [27/40] filter: handle mount errors from CONFIG_BLK_DEV_WRITE_MOUNTED=y [28/40] filters: add a filter that accepts EIO instead of other errors [29/40] generic/085: general cleanup for reliability and debugging [30/40] fstests: don't use directory stacks [31/40] fstests: clean up a couple of dm-flakey tests [32/40] fstests: clean up termination of various tests [33/40] vfstests: some tests require the testdir to be shared [34/40] xfs/629: single extent files should be within tolerance [35/40] xfs/076: fix broken mkfs filtering [36/40] fstests: capture some failures to seqres.full [37/40] fstests: always use fail-at-unmount semantics for XFS [38/40] generic/062: don't leave debug files in $here on failure [39/40] fstests: quota grace periods unreliable under load [40/40] fstests: check-parallel

Message ID

20241127045403.3665299-36-david@fromorbit.com (mailing list archive)

State

New

Headers

From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 35/40] xfs/076: fix broken mkfs filtering
Date: Wed, 27 Nov 2024 15:52:05 +1100
Message-ID: <20241127045403.3665299-36-david@fromorbit.com>
In-Reply-To: <20241127045403.3665299-1-david@fromorbit.com>
References: <20241127045403.3665299-1-david@fromorbit.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

fstests: concurrent test execution | expand

Commit Message

Dave Chinner Nov. 27, 2024, 4:52 a.m. UTC

From: Dave Chinner <dchinner@redhat.com>

The test does not do what it says on the packet - the mkfs output is
not actually passed to the mkfs filter, so it doesn't know what
inode size mkfs actually used. Hence CHUNK_SIZE ends up being
calculated as 0, and that means it enters an endless loop because
offset never decreases.

Fix it by adding the missing line continuation.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/076 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/076 b/tests/xfs/076
index e315a067c..2ea6459b0 100755
--- a/tests/xfs/076
+++ b/tests/xfs/076
@@ -68,7 +68,7 @@  _require_xfs_sparse_inodes
 # bitmap consuming all the free space in our small data device.
 unset SCRATCH_RTDEV
 
-_scratch_mkfs "-d size=96m -m crc=1 -i sparse" | tee -a $seqres.full |
+_scratch_mkfs "-d size=96m -m crc=1 -i sparse" | tee -a $seqres.full | \
 	_filter_mkfs > /dev/null 2> $tmp.mkfs
 . $tmp.mkfs	# for isize

[35/40] xfs/076: fix broken mkfs filtering

Commit Message

Patch