| Message ID | 20241215051242.3340572-2-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix recent regressions from for_next | expand |
On Sun, Dec 15, 2024 at 12:12:41AM -0500, Theodore Ts'o wrote: > This fixes a regression for ext4 introduced by commit 32e14cb90b88 > ("fstests: don't use directory stacks"), which replaced a number of > files at the top-level of the scratch file system: > > async_file sync_file direct_file trunc_file > > with "rm $SCRATCH_MNT/*". This causes a test failure on ext4 file > systems caused by a failed attempt to unlink the lost+found directory. > The thing, is these files are all super small (4k or 16k) and the > scratch file system is going to get reformatted before it gets used > again. So just dropping the delete is the simplest way to solve the > problem. > > Fixes: 32e14cb90b88 ("fstests: don't use directory stacks") > Signed-off-by: Theodore Ts'o <tytso@mit.edu> Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/tests/generic/135 b/tests/generic/135 index 392fee6fc..f74e144f3 100755 --- a/tests/generic/135 +++ b/tests/generic/135 @@ -40,7 +40,5 @@ od -Ad -x $SCRATCH_MNT/sync_file od -Ad -x $SCRATCH_MNT/direct_file od -Ad -x $SCRATCH_MNT/trunc_file -rm -f $SCRATCH_MNT/* - status=0 exit
This fixes a regression for ext4 introduced by commit 32e14cb90b88 ("fstests: don't use directory stacks"), which replaced a number of files at the top-level of the scratch file system: async_file sync_file direct_file trunc_file with "rm $SCRATCH_MNT/*". This causes a test failure on ext4 file systems caused by a failed attempt to unlink the lost+found directory. The thing, is these files are all super small (4k or 16k) and the scratch file system is going to get reformatted before it gets used again. So just dropping the delete is the simplest way to solve the problem. Fixes: 32e14cb90b88 ("fstests: don't use directory stacks") Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- tests/generic/135 | 2 -- 1 file changed, 2 deletions(-)