diff mbox series

generic/420: skip test for ocfs2

Message ID 20250106140131.91946-1-glass.su@suse.com (mailing list archive)
State New
Headers show
Series generic/420: skip test for ocfs2 | expand

Commit Message

Glass Su Jan. 6, 2025, 2:01 p.m. UTC 
ocfs2 doesn't support fallocate with
mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE so skip it.

Signed-off-by: Su Yue <glass.su@suse.com>
---
 tests/generic/420 | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Jan. 6, 2025, 4:31 p.m. UTC | #1 
On Mon, Jan 06, 2025 at 10:01:31PM +0800, Su Yue wrote:
> ocfs2 doesn't support fallocate with
> mode=FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE so skip it.
> 
> Signed-off-by: Su Yue <glass.su@suse.com>
> ---
>  tests/generic/420 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/420 b/tests/generic/420
> index edd9655fd3a3..e67442f8979b 100755
> --- a/tests/generic/420
> +++ b/tests/generic/420
> @@ -15,6 +15,7 @@ _begin_fstest auto quick punch
>  
>  
>  # Modify as appropriate.
> +_supported_fs ^ocfs2
>  _require_test
>  _require_xfs_io_command fpunch

_require_xfs_io_command should be checking for hole punch
support.  If that doesn't work we'll need to fix it instead
of throwing in undocumented blacklisting of file system types.
diff mbox series

Patch

diff --git a/tests/generic/420 b/tests/generic/420
index edd9655fd3a3..e67442f8979b 100755
--- a/tests/generic/420
+++ b/tests/generic/420
@@ -15,6 +15,7 @@  _begin_fstest auto quick punch
 
 
 # Modify as appropriate.
+_supported_fs ^ocfs2
 _require_test
 _require_xfs_io_command fpunch