diff mbox series

xfs/32: fix test failure on kernels which don't support bs > ps

Message ID 20250117190659.3189518-1-tytso@mit.edu (mailing list archive)
State New
Headers show
Series xfs/32: fix test failure on kernels which don't support bs > ps | expand

Commit Message

Theodore Ts'o Jan. 17, 2025, 7:06 p.m. UTC
When trying to mount a file system with a block size > page size on
kernel which doesn't support this, suppress the error messages from
showing up in the output file lest it cause test failures.

Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/xfs/032 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Jan. 17, 2025, 9:02 p.m. UTC | #1
On Fri, Jan 17, 2025 at 02:06:59PM -0500, Theodore Ts'o wrote:
> When trying to mount a file system with a block size > page size on
> kernel which doesn't support this, suppress the error messages from
> showing up in the output file lest it cause test failures.
> 
> Fixes: 0b66f6efd669 ("xfs/032: try running on blocksize > pagesize filesystems")
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  tests/xfs/032 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/032 b/tests/xfs/032
> index 41a9134d8..9c1741cf1 100755
> --- a/tests/xfs/032
> +++ b/tests/xfs/032
> @@ -44,7 +44,7 @@ for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
>  		if [ $? -ne 0 ]; then
>  			continue
>  		fi
> -		if ! _try_scratch_mount; then
> +		if ! _try_scratch_mount >& /dev/null ; then

Should we dump that to $seqres.full instead of discarding it?

--D

>  			if [ $BLOCKSIZE -le $PAGESIZE ]; then
>  				_fail "mount $(_scratch_mount_options $*) failed"
>  			fi
> -- 
> 2.45.2
> 
>
diff mbox series

Patch

diff --git a/tests/xfs/032 b/tests/xfs/032
index 41a9134d8..9c1741cf1 100755
--- a/tests/xfs/032
+++ b/tests/xfs/032
@@ -44,7 +44,7 @@  for ((; SECTORSIZE <= 65536; SECTORSIZE *= 2)); do
 		if [ $? -ne 0 ]; then
 			continue
 		fi
-		if ! _try_scratch_mount; then
+		if ! _try_scratch_mount >& /dev/null ; then
 			if [ $BLOCKSIZE -le $PAGESIZE ]; then
 				_fail "mount $(_scratch_mount_options $*) failed"
 			fi