| Message ID | 20250128071315.676272-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] generic/363: remove _supported_fs xfs | expand |
On Tue, Jan 28, 2025 at 08:12:58AM +0100, Christoph Hellwig wrote: > Run this test for all file systems. Just because they are broken doesn't > mean that zeroing should not be tested. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Brian Foster <bfoster@redhat.com> /me notes that this fails on btrfs, though it seems ext4 is ok..... Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > tests/generic/363 | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/generic/363 b/tests/generic/363 > index 477c111ccb60..74226a458427 100755 > --- a/tests/generic/363 > +++ b/tests/generic/363 > @@ -13,9 +13,6 @@ _begin_fstest rw auto > > _require_test > > -# currently only xfs performs enough zeroing to satisfy fsx > -_supported_fs xfs > - > # on failure, replace -q with -d to see post-eof writes in the dump output > run_fsx "-q -S 0 -e 1 -N 100000" > > -- > 2.45.2 > >
On Tue, Jan 28, 2025 at 11:17:06AM -0800, Darrick J. Wong wrote: > On Tue, Jan 28, 2025 at 08:12:58AM +0100, Christoph Hellwig wrote: > > Run this test for all file systems. Just because they are broken doesn't > > mean that zeroing should not be tested. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Brian Foster <bfoster@redhat.com> > > /me notes that this fails on btrfs, though it seems ext4 is ok..... Well, we should not skip tests because they fail, the point is to show something is broken..
diff --git a/tests/generic/363 b/tests/generic/363 index 477c111ccb60..74226a458427 100755 --- a/tests/generic/363 +++ b/tests/generic/363 @@ -13,9 +13,6 @@ _begin_fstest rw auto _require_test -# currently only xfs performs enough zeroing to satisfy fsx -_supported_fs xfs - # on failure, replace -q with -d to see post-eof writes in the dump output run_fsx "-q -S 0 -e 1 -N 100000"