| Message ID | 20250304234819.783-1-ailiop@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | generic/633: add _require_idmapped_mounts check | expand |
On Wed, 5 Mar 2025 00:48:19 +0100, Anthony Iliopoulos wrote: > Skip the test on older kernels that don't implement mount_setattr and > open_tree syscalls, instead of failing. > > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> > --- > tests/generic/633 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/633 b/tests/generic/633 > index 3bd18df68ba5..f58dbbf5f222 100755 > --- a/tests/generic/633 > +++ b/tests/generic/633 > @@ -12,7 +12,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink > # Import common functions. > . ./common/filter > > - > +_require_idmapped_mounts > _require_test > > echo "Silence is golden" Looks good, although generic/696 and generic/697 probably should be covered too. Reviewed-by: David Disseldorp <ddiss@suse.de>
On Wed, Mar 05, 2025 at 02:10:43PM +1100, David Disseldorp wrote: > On Wed, 5 Mar 2025 00:48:19 +0100, Anthony Iliopoulos wrote: > > > Skip the test on older kernels that don't implement mount_setattr and > > open_tree syscalls, instead of failing. > > > > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> > > --- > > tests/generic/633 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/generic/633 b/tests/generic/633 > > index 3bd18df68ba5..f58dbbf5f222 100755 > > --- a/tests/generic/633 > > +++ b/tests/generic/633 > > @@ -12,7 +12,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink > > # Import common functions. > > . ./common/filter > > > > - > > +_require_idmapped_mounts > > _require_test > > > > echo "Silence is golden" > > Looks good, although generic/696 and generic/697 probably should be > covered too. > > Reviewed-by: David Disseldorp <ddiss@suse.de> Thanks David points out that:) Hi Anthony, if you'd like to fix missed "_require_idmapped_mounts", could you help to fix above two cases together. With that change: Reviewed-by: Zorro Lang <zlang@redhat.com> >
diff --git a/tests/generic/633 b/tests/generic/633 index 3bd18df68ba5..f58dbbf5f222 100755 --- a/tests/generic/633 +++ b/tests/generic/633 @@ -12,7 +12,7 @@ _begin_fstest auto quick atime attr cap idmapped io_uring mount perms rw unlink # Import common functions. . ./common/filter - +_require_idmapped_mounts _require_test echo "Silence is golden"
Skip the test on older kernels that don't implement mount_setattr and open_tree syscalls, instead of failing. Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> --- tests/generic/633 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)