diff mbox series

[4/3] common/populate: drop fallocate mode 0 requirement

Message ID 20250314175449.GL2803740@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [1/3] xfs/614: determine the sector size of the fs image by doing a test format | expand

Commit Message

Darrick J. Wong March 14, 2025, 5:54 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

None of the _scratch_$FSTYP_populate functions use fallocate mode 0 (aka
preallocation) to run, so drop the _require check.  This enables xfs/349
and friends to work on always-cow xfs filesystems.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 common/populate |    1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Hellwig March 18, 2025, 5:49 a.m. UTC | #1 
On Fri, Mar 14, 2025 at 10:54:49AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> None of the _scratch_$FSTYP_populate functions use fallocate mode 0 (aka
> preallocation) to run, so drop the _require check.  This enables xfs/349
> and friends to work on always-cow xfs filesystems.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/common/populate b/common/populate
index a1be26d5b24adf..7352f598a0c700 100644
--- a/common/populate
+++ b/common/populate
@@ -8,7 +8,6 @@ 
 . ./common/quota
 
 _require_populate_commands() {
-	_require_xfs_io_command "falloc"
 	_require_xfs_io_command "fpunch"
 	_require_test_program "punch-alternating"
 	_require_test_program "popdir.pl"