From patchwork Fri Jun 2 08:23:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 9761913 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7147F60360 for ; Fri, 2 Jun 2017 08:24:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 619FA27F89 for ; Fri, 2 Jun 2017 08:24:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54B4428548; Fri, 2 Jun 2017 08:24:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AEC9127F89 for ; Fri, 2 Jun 2017 08:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751141AbdFBIXy (ORCPT ); Fri, 2 Jun 2017 04:23:54 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34877 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdFBIXu (ORCPT ); Fri, 2 Jun 2017 04:23:50 -0400 Received: by mail-oi0-f43.google.com with SMTP id l18so83177704oig.2 for ; Fri, 02 Jun 2017 01:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=d4bE1bSykV0GB1Nm+PPhrFf16qixpE7KwIv0R5jBL/Q=; b=Uk7+NPi+8KJ8Ahy03HbRyqn9sje5zxJnJDIr6m8E2JjKQ7FOci7Ve+4ag3vTEL4PQ8 vjTmEMFr4CA8bxipP6+qmQWGLP2BEGv1S7dL150A8Yu6ia3ELbUXF//+zOpVkxJIZC91 5L+zZDn5SBMDGYEnDKMZiFlIZi9HpQhlHNsIt/jMCwGRYkIKiHResrOH2e0hqvFPzu/A KFg9+dV3Ku68ez0SukNkIDMtCnQfr7Ykuwyf9y/qKYzD9UKGefi8Astvx3QJV5SWQ12i EVyOMai7MuI4kIGsevphbFohYme4j6s045CKjJQwq4Ypsx2GNJPpDqDPMtOHvgyk6+zF tK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d4bE1bSykV0GB1Nm+PPhrFf16qixpE7KwIv0R5jBL/Q=; b=QsyQnQFkL3HTWHBN+/oEXWolB5wE/QyH9XL7rsQ/G2jKO/RM8l00g2FAT/5Qx9t+OG VYZnVv92BDhkNTdb1Xy2zPfHucnkZXnsx1ed/fzz64DT2O6+zoDtbFUVtl8rVbJ34p+h l7AJPk+K//4SdiFJeyXUO+1jCwe7r+UhkWf3fuXKTzXrvxHfTH+I60Q7Tiqrw2+pHi0f pceIQ3hyGbl+kbUljd8Ul362Fzxfw50oMCFAZua3OdHQOer9hVApLZ7SttAMsniiZy9Y dx/fFaEpvvHZTk1QUZF/4WHxSvrt8jx6qzKKXowkEsGlVxMnWQpgaSkgSK5RHcHBAg5M DSVQ== X-Gm-Message-State: AODbwcDkyrG0N24ZgM1LTrZyVuqn3JfTkYumkQ3NbhUAs69aU1h8aKpm tedehQRq5yDrvpZF X-Received: by 10.84.224.198 with SMTP id k6mr12344817pln.148.1496391829161; Fri, 02 Jun 2017 01:23:49 -0700 (PDT) Received: from localhost.localdomain ([2601:602:8801:8110:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id y2sm38984602pfk.1.2017.06.02.01.23.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2017 01:23:48 -0700 (PDT) From: Omar Sandoval To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: kernel-team@fb.com Subject: [PATCH] generic: test Btrfs delalloc accounting overflow Date: Fri, 2 Jun 2017 01:23:41 -0700 Message-Id: <49a0c7551c337566be29b2c073ba0be57779d321.1496391726.git.osandov@fb.com> X-Mailer: git-send-email 2.13.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Omar Sandoval This is a regression test for "[PATCH] Btrfs: fix delalloc accounting leak caused by u32 overflow". It creates a bunch of delalloc extents and merges them together to make sure the accounting is done right. Signed-off-by: Omar Sandoval --- tests/generic/438 | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/438.out | 2 ++ tests/generic/group | 1 + 3 files changed, 80 insertions(+) create mode 100755 tests/generic/438 create mode 100644 tests/generic/438.out diff --git a/tests/generic/438 b/tests/generic/438 new file mode 100755 index 00000000..8edac03d --- /dev/null +++ b/tests/generic/438 @@ -0,0 +1,77 @@ +#! /bin/bash +# FS QA Test 438 +# +# Test delayed allocation with a large number of extents that are merged. +# Regression test for patch "Btrfs: fix delalloc accounting leak caused by u32 +# overflow". +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Facebook. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +test_file="$TEST_DIR/$seq" + +_cleanup() +{ + cd / + rm -f $tmp.* "$test_file" +} + +. ./common/rc +. ./common/filter + +rm -f $seqres.full + +_supported_fs generic +_supported_os Linux +_require_test + +# Create 32k extents. All of these extents will be accounted as outstanding and +# reserved. +for ((i = 0; i < 32 * 1024; i++)); do + xfs_io -f -c "pwrite $((2 * 4096 * i)) 4096" "$test_file" >>"$seqres.full" +done + +# Fill in the gaps between the created extents. The outstanding extents will +# all be merged into 1, but there will still be 32k reserved. +for ((i = 0; i < 32 * 1024; i++)); do + xfs_io -f -c "pwrite $((2 * 4096 * i + 1)) 4096" "$test_file" >>"$seqres.full" +done + +# Flush the delayed allocations. +sync + +# Make sure that we didn't leak any metadata space. +if [[ $FSTYP = btrfs ]]; then + uuid="$(findmnt -n -o UUID "$TEST_DIR")" + cd "/sys/fs/btrfs/$uuid/allocation" + echo "$(($(cat metadata/bytes_may_use) - $(cat global_rsv_reserved))) bytes leaked" | grep -v '^0 ' +fi + +echo "Silence is golden" + +status=0 +exit diff --git a/tests/generic/438.out b/tests/generic/438.out new file mode 100644 index 00000000..4968f4d7 --- /dev/null +++ b/tests/generic/438.out @@ -0,0 +1,2 @@ +QA output created by 438 +Silence is golden diff --git a/tests/generic/group b/tests/generic/group index 438c2990..c804b05d 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -440,3 +440,4 @@ 435 auto encrypt 436 auto quick rw 437 auto quick +438 auto