diff mbox series

[01/12] add t_reflink_read_race to .gitignore file

Message ID 578579505765ce6bb5ee8b1cc0e1703221fd9acc.1707969354.git.anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show
Series btrfs: functional test cases for tempfsid | expand

Commit Message

Anand Jain Feb. 15, 2024, 6:34 a.m. UTC
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Filipe Manana Feb. 15, 2024, 11:45 a.m. UTC | #1
On Thu, Feb 15, 2024 at 6:34 AM Anand Jain <anand.jain@oracle.com> wrote:
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>

Please always add a changelog...

Also, you need to update your local checkout...
This was already fixed before:

https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?h=for-next&id=acff198213e3d874e76f6a133a816c8dee5e128d

It's also odd to include this in a patchset for the tempfsid feature,
as it's completely unrelated, it should go as a separate patch.

Thanks.

> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 5cc3a5e4ae57..d930b9cc8404 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -204,6 +204,7 @@ tags
>  /src/vfs/mount-idmapped
>  /src/log-writes/replay-log
>  /src/perf/*.pyc
> +/src/t_reflink_read_race
>
>  # Symlinked files
>  /tests/generic/035.out
> --
> 2.39.3
>
>
Anand Jain Feb. 15, 2024, 11:50 a.m. UTC | #2
On 2/15/24 17:15, Filipe Manana wrote:
> On Thu, Feb 15, 2024 at 6:34 AM Anand Jain <anand.jain@oracle.com> wrote:
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> 
> Please always add a changelog...
> 
> Also, you need to update your local checkout...

Oh no. I thought I did.


> This was already fixed before:
> 
> https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?h=for-next&id=acff198213e3d874e76f6a133a816c8dee5e128d


> 
> It's also odd to include this in a patchset for the tempfsid feature,
> as it's completely unrelated, it should go as a separate patch.
> 

I should have.

I'll drop this patch in v2 (if any).

Thanks, Anand

> Thanks.
> 
>> ---
>>   .gitignore | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 5cc3a5e4ae57..d930b9cc8404 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -204,6 +204,7 @@ tags
>>   /src/vfs/mount-idmapped
>>   /src/log-writes/replay-log
>>   /src/perf/*.pyc
>> +/src/t_reflink_read_race
>>
>>   # Symlinked files
>>   /tests/generic/035.out
>> --
>> 2.39.3
>>
>>
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 5cc3a5e4ae57..d930b9cc8404 100644
--- a/.gitignore
+++ b/.gitignore
@@ -204,6 +204,7 @@  tags
 /src/vfs/mount-idmapped
 /src/log-writes/replay-log
 /src/perf/*.pyc
+/src/t_reflink_read_race
 
 # Symlinked files
 /tests/generic/035.out