diff mbox series

[3/3] common/rc: source common/xfs and common/btrfs

Message ID 8d7db41971a227c5bd83677464d139399607e720.1604000570.git.riteshh@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series fstests: Fix tests which checks for swapfile support | expand

Commit Message

Ritesh Harjani Oct. 29, 2020, 7:52 p.m. UTC
Without this patch I am unable to test for multiple different
filesystem sections for the same tests. Since we anyway have only
function definitions in these files, so it should be ok to source it
by default too.
e.g. when I run ./check -s btrfs tests/generic/613 with 3 different [***_fs]
sections from local.config file, I see below failures.

./common/rc: line 2801: _check_btrfs_filesystem: command not found

./check -s xfs_4k -g swap (for XFS this fails like below)
./common/rc: line 749: _scratch_mkfs_xfs: command not found
check: failed to mkfs $SCRATCH_DEV using specified options

Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
 common/rc | 2 ++
 1 file changed, 2 insertions(+)

Comments

Darrick J. Wong Oct. 29, 2020, 9:04 p.m. UTC | #1
On Fri, Oct 30, 2020 at 01:22:53AM +0530, Ritesh Harjani wrote:
> Without this patch I am unable to test for multiple different
> filesystem sections for the same tests. Since we anyway have only
> function definitions in these files, so it should be ok to source it
> by default too.
> e.g. when I run ./check -s btrfs tests/generic/613 with 3 different [***_fs]
> sections from local.config file, I see below failures.
> 
> ./common/rc: line 2801: _check_btrfs_filesystem: command not found
> 
> ./check -s xfs_4k -g swap (for XFS this fails like below)
> ./common/rc: line 749: _scratch_mkfs_xfs: command not found
> check: failed to mkfs $SCRATCH_DEV using specified options
> 
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
>  common/rc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 4c59968a6bd3..e9ba1b6e8265 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3,6 +3,8 @@
>  # Copyright (c) 2000-2006 Silicon Graphics, Inc.  All Rights Reserved.
>  
>  . common/config
> +. ./common/xfs
> +. ./common/btrfs

Uhh, what happens if you run xfs and nfs one after the other?

--D

>  
>  BC=$(which bc 2> /dev/null) || BC=
>  
> -- 
> 2.26.2
>
diff mbox series

Patch

diff --git a/common/rc b/common/rc
index 4c59968a6bd3..e9ba1b6e8265 100644
--- a/common/rc
+++ b/common/rc
@@ -3,6 +3,8 @@ 
 # Copyright (c) 2000-2006 Silicon Graphics, Inc.  All Rights Reserved.
 
 . common/config
+. ./common/xfs
+. ./common/btrfs
 
 BC=$(which bc 2> /dev/null) || BC=