diff mbox series

[1/2] fstests: update sparse file & negative timestamp tests for exfat

Message ID 931ccb70-0b72-6532-d859-e355264d299a@sandeen.net (mailing list archive)
State New, archived
Headers show
Series fstests: 2 more exfat-related fixes | expand

Commit Message

Eric Sandeen May 6, 2020, 10:16 p.m. UTC 
exfat cannot do sparse files or negative timestamps, so exclude
tests which require these.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Comments

Christoph Hellwig May 8, 2020, 12:05 p.m. UTC | #1 
On Wed, May 06, 2020 at 05:16:50PM -0500, Eric Sandeen wrote:
> exfat cannot do sparse files or negative timestamps, so exclude
> tests which require these.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/common/rc b/common/rc
index 2734dbf6..e90c12a3 100644
--- a/common/rc
+++ b/common/rc
@@ -2357,7 +2357,7 @@  _require_fs_space()
 _require_sparse_files()
 {
     case $FSTYP in
-    hfsplus)
+    hfsplus|exfat)
         _notrun "Sparse files not supported by this filesystem type: $FSTYP"
 	;;
     *)
@@ -4188,9 +4188,10 @@  _check_xfs_scrub_does_unicode() {
 	return 0
 }
 
+# exfat timestamps start at 1980 and cannot be prior to epoch
 _require_negative_timestamps() {
 	case "$FSTYP" in
-	ceph)
+	ceph|exfat)
 		_notrun "$FSTYP does not support negative timestamps"
 		;;
 	esac