From patchwork Sun Jul 31 21:53:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 9253537 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6080B6075F for ; Sun, 31 Jul 2016 21:59:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45BBD2823D for ; Sun, 31 Jul 2016 21:59:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3547E28464; Sun, 31 Jul 2016 21:59:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09A1D2823D for ; Sun, 31 Jul 2016 21:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbcGaV7w (ORCPT ); Sun, 31 Jul 2016 17:59:52 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35502 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbcGaV7w (ORCPT ); Sun, 31 Jul 2016 17:59:52 -0400 Received: by mail-pf0-f173.google.com with SMTP id x72so48507755pfd.2 for ; Sun, 31 Jul 2016 14:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=fmD3fQ2GM9fqW3P46fmgK5i1k0P/IxclKBAXUCjmSvI=; b=KbIu8T+3MFAH+hA/4ofg6esngTjS6rMrRoazr7EZsDGVm6iyiEkKMjhgbO8WjE1fLf Ry5oc5363iIpprChCSdLn+1HPgLd7jfw0EvrRg0CGmhCYGW/MfpjCdBYr3mXjkjWQuR7 jbdU3oqDZArdMAuOoMrX3SbVJ+QgsHCR/mtQdLFaiguUFnghSqt2q2d4MbHZQ5HPtYf9 wNiAVjgKDzZAazkYp7ex84+sV9+8laqWHtkBKHHE+cxa0qX/dKPipE5kWS/IouMicOAs l5S7CicCyIVebT5qmVcsKNeh6BciJ5UNpvwkyoKzeAf+KrLaXRIA95nlg59lgoH02j1w itPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fmD3fQ2GM9fqW3P46fmgK5i1k0P/IxclKBAXUCjmSvI=; b=V/DaMnirF907xp2hi5m2KE6WpVojUSxCEdbdJBndXeMfqZ0ZCAP716DkLbYlcQ22wS jzugVYpdTYoIxk8Fd54JSITU42sqfcGyzVjJ1oeMHE4k893YG497OW9+yfIfQO00ekWs DfmDq4o8QfisfWjgy8425DS2UYUwe38/Lg6uDxsO7sJV/uhhPmM5LqJVr12BazeE+evo fsIis4U5z+eBJB5EbkZWXGcOtKPzCyvD+AYKEvg8es6SWMLy7Qfofd5cMw97dY+TA+1z HLseJ1uMC44wKCMPGgFegOhKaUqPxUoZlmpiCSLPmkTGEcL26eG4OQ+XAstgamBUweOd zs2A== X-Gm-Message-State: AEkooutPe7RjI4rlsBNQU6mdDhh+5sACLCwfaarSeg28T4srT4C7DKff5XSNnrsVhijzuGXr X-Received: by 10.98.75.219 with SMTP id d88mr90101091pfj.91.1470002038321; Sun, 31 Jul 2016 14:53:58 -0700 (PDT) Received: from localhost.localdomain ([2601:602:8801:8110:1a5e:fff:fea7:e0ef]) by smtp.gmail.com with ESMTPSA id f3sm40161080pff.26.2016.07.31.14.53.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Jul 2016 14:53:57 -0700 (PDT) From: Omar Sandoval To: fstests@vger.kernel.org Cc: kernel-team@fb.com Subject: [PATCH] check: allow comments in exclude files Date: Sun, 31 Jul 2016 14:53:44 -0700 Message-Id: X-Mailer: git-send-email 2.9.2 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Omar Sandoval Sometimes it's useful to keep track of why we're excluding a particular test. Technically, we can include whatever explanation we want in the exclude file since we just grep for the test names, but properly supporting comments is a little more robust. This patch makes it so that the rest of a line after a '#' is ignored. Signed-off-by: Omar Sandoval Reviewed-by: Dave Chinner --- check | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check b/check index 9fbc305e9021..69341d8c4f72 100755 --- a/check +++ b/check @@ -224,14 +224,14 @@ while [ $# -gt 0 ]; do -X) xfile=$2; shift ; for d in $SRC_GROUPS $FSTYP; do [ -f $SRC_DIR/$d/$xfile ] || continue - for f in `cat $SRC_DIR/$d/$xfile`; do + for f in `sed "s/#.*$//" $SRC_DIR/$d/$xfile`; do echo $d/$f >> $tmp.xlist done done ;; -E) xfile=$2; shift ; if [ -f $xfile ]; then - cat "$xfile" >> $tmp.xlist + sed "s/#.*$//" "$xfile" >> $tmp.xlist fi ;; -s) RUN_SECTION="$RUN_SECTION $2"; shift ;;